Coder Social home page Coder Social logo

Comments (3)

danielbachhuber avatar danielbachhuber commented on August 17, 2024

Thanks for the report, @Roy-Orbison !

We can definitely try to fix up the URL syntaxes you think are broken. I'm having a little bit of a hard time grokking your report, though. Which syntaxes would you like to see supported?

from package-command.

Roy-Orbison avatar Roy-Orbison commented on August 17, 2024

In this docs section, it states that adding a module is done like so, the last parameter looking like a typical Git URL:

wp package install [email protected]:wp-cli/dist-archive-command.git

These all failed:

  • https://github.com/wp-cli/search-replace-command.git
  • github:wp-cli/search-replace-command.git (where github: is an SSH alias that sets the user and selects the SSH key)
  • github:wp-cli/search-replace-command.git:dev-main (trying to select correct branch)
  • https://github.com/wp-cli/search-replace-command.git:dev-main

What worked was wp-cli/search-replace-command:dev-main, which I gleaned from this issue comment where someone else had encountered the invalid default branch dev-master.

You don't necessarily have to support those URL types, more that the docs didn't match the experience, so maybe something needs to be updated.

from package-command.

danielbachhuber avatar danielbachhuber commented on August 17, 2024

Thanks, @Roy-Orbison.

I think we should:

  • Support additional URL patterns where doing so wouldn't cause a backcompat break.
  • Document the URL patterns we don't support because they conflict with some existing pattern.

In honestly, what's most likely is that the additional URL patterns weren't considered when the feature was created.

Feel free to submit a pull request, if you'd like. Here is some guidance on our pull request best practices.

from package-command.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.