Comments (8)
so after making the changes required I found some old related issues where this exact change was abandoned because Composer 2.3 is not compatible with PHP 5.6:
@stefanfisk Ah, good find.
So as long as PHP 5.6 compatibility is required this is not fixable. I'm not familiar with the PHP compatibility policy for WP-CLI, is PHP 5.6 compatiblity still required? And if it is, is there any end date for said compatiblity requirement? 5.6 is absolutely ancient by now :/
We'll need to support support PHP 5.6 at least as long as WordPress core supports 5.6. Fortunately, that should be over soon.
In 2019, our plan was to support PHP 5.6 for at least a year after core removed support. It seems like we may need to revisit that, though.
from package-command.
@stefanfisk I think some fixes are needed for this: https://github.com/wp-cli/package-command/actions/runs/4189588371/jobs/7262087460#step:13:318
from package-command.
@danielbachhuber do you know anything specific that needs fixing, or is it just untested?
from package-command.
@danielbachhuber cool, that looks easy enough. Is it OK to go with only ^2.5.4
, or is ^1.10.23
still needed as well?
from package-command.
@stefanfisk We can remove ^1.10.23
as long as there aren't any backwards-compat issues.
from package-command.
@danielbachhuber so after making the changes required I found some old related issues where this exact change was abandoned because Composer 2.3 is not compatible with PHP 5.6: #151 #152
So as long as PHP 5.6 compatibility is required this is not fixable. I'm not familiar with the PHP compatibility policy for WP-CLI, is PHP 5.6 compatiblity still required? And if it is, is there any end date for said compatiblity requirement? 5.6 is absolutely ancient by now :/
from package-command.
As a workaround, I switch from wp-cli-bundle
to requiring the individual packages except for package-command
.
It's a bit ugly, but would you be OK with having to implementations of ComposerIO
, one with types and one without, and then have ComposerIO.php require the correct one based on PHP_MAJOR_VERSION
?
from package-command.
It's a bit ugly, but would you be OK with having to implementations of
ComposerIO
, one with types and one without, and then have ComposerIO.php require the correct one based onPHP_MAJOR_VERSION
?
@stefanfisk Yes, that would be a perfectly fine approach
from package-command.
Related Issues (20)
- installing package on Intranet HOT 3
- Unable to install packages on Windows and PHP7.3.1 HOT 13
- Adopt and enforce new `WP_CLI_CS` standard HOT 2
- Allow install from a Git repository specific branch HOT 3
- check_git_package_name hardcode reference to GitHub HOT 2
- Commands Cookbook link goes to a 404 HOT 1
- Lock framework to stable version again before release
- Compatibility with Composer 2 HOT 7
- Legacy package index prevents installation of current release of a package HOT 2
- Allow composer ^2.0 HOT 6
- SSL certificate problem: certificate has expired HOT 9
- Declaration of WP_CLI\ComposerIO::isVerbose() and others not compatible with Composer\IO\NullIO::isVerbose(): bool HOT 2
- Restore 'Install a package with a dependency' test
- Errors installing command into development environment HOT 3
- Add command to get information about single package HOT 4
- Move command over to new v2 structure
- Prefer packagist.org over Github
- Automatically rerun failed scenarios
- Broke composer commands when used with phpcodesniffer-composer-installer HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from package-command.