Coder Social home page Coder Social logo

Comments (25)

lecorguille avatar lecorguille commented on May 23, 2024 1

To really close this thread

Here is a little screencast about how to run in parallel xcmsSet within W4M using single files [link]

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

We will be able to carry on new developments since planemo shed_test for all tools in this repo
#3

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

Let's go!
#13

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

In progress: #13
Need to be tested

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

Available from the testtoolshed since the version 2.1.0
docker run -d -p 8080:80 quay.io/workflow4metabolomics/galaxy-workflow4metabolomics:beta

The CAMERA part will fail. I'm working on that workflow4metabolomics/camera.archive#15

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

Available within the dev galaxy instance

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

Unfortunatly, we can't currently import CDF file in the dev instance because it need to be updated.
By can you try with some other format to:

  • launch as many xcmsSet as input file

  • merge the rdata with xcms.merger

  • launch the whole workflow until camera

  • validated by @melpetera

  • validated by @yguitton

  • validated by @jfrancoismartin

  • validated by @pierrickrogermele

from tools-metabolomics.

melpetera avatar melpetera commented on May 23, 2024

Can't manage to make the merge work:

Tool execution generated the following error message:

Fatal error: Exit code 1 ()
Warning message:
'loadRcppModules' is deprecated.
Use 'loadModule' instead.
See help("Deprecated") 
Error in peaklist[[i]][, "sample"] : subscript out of bounds
Calls: c -> c.xcmsSet
Execution halted

The tool produced the following additional output:

	XSET MERGING...
QC_1 
QC_2 

from tools-metabolomics.

sneumann avatar sneumann commented on May 23, 2024

Need more debugging information. The warning is from package mzR and Rcpp,
but should (?!) still work. If not, I need to add a sanity check to c.xcmsSet().
In which R file is this c(xs1, xs2, ...) called ?

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

@melpetera I observed this behaviour when I merge MM8 and MM14 obtained with the default parameters of xcmsSet.
I got this kind of xset:

	XSET OBJECT INFO
An "xcmsSet" object with 1 samples

Time range: Inf--Inf seconds (Inf--Inf minutes)
Mass range: Inf--Inf m/z
Peaks: 0 (about 0 per sample)
Peak Groups: 0 
Sample classes: .

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

@sneumann Here

from tools-metabolomics.

melpetera avatar melpetera commented on May 23, 2024

Oh right! I didn't notice... I'll try to change my initial xcmsSet parameters.

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

Meanwhile, I should raise and error because currently this kind of result is green

from tools-metabolomics.

melpetera avatar melpetera commented on May 23, 2024

Now that my xcmsSet output files are good, the whole workflow works perfectly!

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

ping at least @melpetera @yguitton

After some nocturnal reflections, I think I should simplified the form around the inputs.

Currently:

      <conditional name="inputs">
            <param name="input" type="select" label="Choose your inputs method" >
                <option value="zip_file" selected="true">Zip file from your history containing your chromatograms</option>
                <option value="single_file">mzXML file from your history</option>
            </param>
            <when value="zip_file">
                <param name="zip_file" type="data" format="no_unzip.zip,zip" label="Zip file" />
            </when>
            <when value="single_file">
                <param name="single_file" type="data" format="mzxml,netcdf" label="Single file" />
            </when>
      </conditional>

So users have to choose the input method between zip_file or single_file (mzxml, ...) and then to select their input in their history.
What do you think about accept in the same param both zip file and individual files?

<param name="file" type="data" format="no_unzip.zip,zip,mzxml,mzml,netcdf,mzdata" label="Single file" />

If you agree with that, unfortunatly, at some point, I will ask you to test again the whole workflow.

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

Pong: @bgruening

from tools-metabolomics.

bgruening avatar bgruening commented on May 23, 2024

ping! :)
I'm definitely in favor of the single input without a choice. So that you put everything in one format attribute. This should be a much better UX and less code :)
In a long run I would even try to remove the zip from the supported file types.

Stupid question what happens if in the zip are 10 files?

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

Done: #44

Available within the dev galaxy instance

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

@yguitton
The datatype netCDF and mzData are now supported within the galaxydev instance
Try again! :)

from tools-metabolomics.

melpetera avatar melpetera commented on May 23, 2024

Tested on dev galaxy instance:

  • single input without a choice
  • Run xcmsSet on each input file individually
  • xcms.xcmsSet Merger
  • reaching fillPeaks from individual input files

from tools-metabolomics.

sneumann avatar sneumann commented on May 23, 2024

Cool! What is the link to the dev galaxy instance ?

from tools-metabolomics.

yguitton avatar yguitton commented on May 23, 2024

OK for xcmSet
OK single and multiple mzXML
OK for single & multiple CDF in a zip
OK for single & multiple mzData in a zip

Note still accent issue if some are present inside mzXML files

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

@sneumann The URL is https://galaxydev.workflow4metabolomics.org
If you have trouble to login, let me know :)

from tools-metabolomics.

lecorguille avatar lecorguille commented on May 23, 2024

Validated 👍
Thanks to my testers

from tools-metabolomics.

jfrancoismartin avatar jfrancoismartin commented on May 23, 2024

Sorry for the delay.
I made some mistakes in my tests...
Everything is ok for me now.

from tools-metabolomics.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.