wolfsblvt / advancedpolls Goto Github PK

When showing voters on scoring and multivalued polls, more information can be shown (number of voters, number of votes per voter, etc.) both for regular users and for mods.

When a user does not have permission to see poll votes, he/she is not warned that the voting is visible. The condition to show the message should change.

Add an admin/mod level permission to see all voters of a poll, regardless of specific poll settings.

Permission u_see_voters is global, cannot be set by forum. It should be possible to have this extra granularity. So, we should remove u_see_voters permission, and replace it with local permission f_seevoters, make appropriate checks and changes to code, and register a new event to properly classify this permission as a "Forum/Poll" category permission.

For some polls, you don't want to vote, or you even cant.
It is not good that you have to click on "see results" every time then if you want to see the results.

Also there could be problems with things like the Portal extensions where polls are shown where you haven't voted. The will not vanish there.

Add functionality to allow for polls to attach different votes to several options. For example, give 10 points, to at most 4 options, with at most 4 points per option, out of a total of 15 options...
This will allow "contest" votings.

Replace by request class.

Test for a variable without verifying it is set, line 163 of advancedpolls.php

When changing votes on choice where are showed other votes, then string "None" is added after voters. When done multiple times it leads for example to this: "Voters: UshirewNone, None, biosek"

The "no vote" behaviour is currently not controlled by an ACP switch, there should be a way to disable this new behaviour.

Also, if you hit the "no vote" link, there is no way to vote later, and that might not be the desired situation.

And, if you do vote on a poll, and changes are allowed for that poll, it should be possible to remove the vote completely, not only change to a different value.

Check that makes sense to validate if user has a limitation to vote.
Also, verify if the event is needed/useful.

Simplify the template modifications by utilizing new events in viewtopic poll block (to be proposed):
Remove the use of "overall_header" event when more specific events may be used.
Remove the need for some JS code by asking for new events or template modifications.
Simplify the PHP code to remove generating HTML "hacks" and moving that to (new) template events.

Dutch language pack: https://www.phpbb.com/community/download/file.php?id=169136

Thanks to Beun12.

This will allow completely "blind" polls: no comments allowed, just votes. This can be done as "voting on closed polls" or as "no comments on open polls", either way.

Always loaded in board language rather than user language.

If the window is small, the text from poll options are clipping over the forum area.

See here: https://www.phpbb.com/community/viewtopic.php?p=13880401#p13880401

I will add Scrutinizer, SensioLabsInsight and CodeClimate to test this extension.

Activates the possibility to vote incrementally, while you have not exhausted your available voting capabilities. Specially relevant with scoring polls.

Only affects language file

This should be part of this extension.
Most of the times I am using "allow change of vote" in my forum. I want to activate this by default, cause users generally forget that.

So if this extension advances the core system, it should be possible to set the default the core options too.

We will ignore the ACP things for now, I will rework that.
There are some issues in core\advancedpolls.php though:

Scrutinizer Issues - core\advancedpolls.php

• The parameter $poll is not used and could be removed.
• The variable $post_data does not exist. Did you forget to declare it?
• It seems like you are calling the size function count() as part of the test condition (Note: Do "$i = 0, $count = count(....) in the declaration part)
• Travis Error: Line 91 | ERROR | Whitespace found at end of line (Link)

@javiexin Can you fix those issues in an additional branch? Should be fast to do, and maybe you will learn something there :P

https://github.com/Wolfsblvt/advancedpolls/blob/master/migrations/v1_2_1_configs.php
That should be integrated in 1.2.0 files.

@javiexin: We are not at 1.2.1 here. :P

So for us, we should deinstall and install the extension again. Too much migration files are bad.

I don't know if I want this extension to be fully covered by tests, but a few easy tests would help a lot.

After a poll has ended, the message "Please note that if you vote, your vote will be visible." should not show up any longer. In fact, the message should only be shown if the user is (still) able to cast a vote (so, if the poll does not allow vote changes and the user has voted, this should not show either, even if the poll has not ended).

I am currently in the development of a tool wich will make creation of an ACP module much easier. I will add this to this extension as well. Just to keep that up to date. so advancedpolls_module.php does not need any rework at the current place.

After extension is disabled and data removed, the database shows that the table columns inserted by the "migration" schema files are still present. Might be lack of revert code for those. The config variables are deleted properly, without revert code.

It is possible and simpler to do an all PHP option, still AJAX based.

File: https://www.phpbb.com/community/download/file.php?id=169141

Thank you to tamarin

"Maybe I found a small bug, but it could be feature. When I (as admin) edit already existing topic to add poll it seems that default options (from ACP) are not mirrored in the poll editor (they are unticked). When I create new topic, everything is OK."

Reported here: https://www.phpbb.com/community/viewtopic.php?p=14033241#p14033241

Specifically, updating the AJAX/JS functionality to support reordering after voting if results are to be shown. Not immediate, needs prior work. But this will have to be completed.

To prevent people from using this extensions with phpBB versions that are not supported, a small check should be implemented.

Nullifying the vote by looking at poll results is good, yet wouldn't be possible to show a non voters counter and even their nicknames if the show voters option is enabled?

Requires the availability of https://github.com/phpbb/phpbb/pull/3567/files, likely 3.1.5

phpBBs minimum requirement for php is 5.3.3, so if I could reach it without much work, I should do that.

Hello,
I appreciate the absolute expiring time implemented in Advanced polls, yet I think it would be handy to have it relative instead, by adding a drop-down menu to specify if specified expiration number is 'days' or 'hours'.
Would it be harder to implement it that way?

Anyway, if you don't want (or can't) sort it that way, could you at least make faster to specify an absolute date/time, for example by adding the 'Today' link to autocompile year, month and day with current date and/or use some drop-down menus instead of number fields?

Currently, the only way to specify the poll duration is by a number of days since posting the poll. This is not too granular, and limits the possibility to specify precisely when a poll ends, such as Midnight on Sunday, or so...
There should be a way to specify the poll end date/time in a more precise way, when publishing the poll.

Should be removed in migration file.

Should be integrated with the phpBB notification system.

What do you think about that, @javiexin?

Change the overload of view=viewpoll into an specific option, to avoid confusion.

see https://scrutinizer-ci.com/g/Wolfsblvt/advancedpolls/issues/master/files/core/advancedpolls.php?selectedSeverities%5B0%5D=10&orderField=path&order=asc#inspectioncomment-781479450

If a poll has guest votes, the messages that show with "Show poll voters" may be inconsistent. For example, a poll may have a number of "guest" votes, and no registered voters, then the message will show as "Voters: None" and have a number of votes. Similarly, if you vote on such a poll, the new message will show "Voters: None, user".

Suggestion: we could use just one drop-down or radio-button control to specify the poll visibility, and another control to specify vote change possibilities, greatly simplifying the posting options while being much more complete.

Visibility options:

• Public: results are always shown (new option)
• Default: results are shown after first vote, or when poll has ended
• Vote completed: results are shown after last vote, or when poll has ended (new option)
• Private: results are shown only when poll has ended (same as "hidden" today)

Vote change options:

• No change: you vote once and only once, nothing can be changed after
• Incremental voting: you may vote as many times as you want while you have pending votes to send (for polls with multiple options to choose, or scoring polls), but once you send a vote you cannot change it (same as "incremental" today)
• Change: you may change your vote as many times as you want while the poll is open

Two things that are "kind of" here as well are:

• No-vote: could be an option to visibility (another level?), or an ACP control to change "vote peeking" into no-vote (as it is now)
• Remove vote: could be an option to change votes (another level?), or an ACP control to add this to "Change votes"

We could also save in storage, by having a single DB field for each of these, rather than multiple binary fields.

What do you think? I can implement this if it makes sense.

No need to remove permission in migration file, this is done with uninstall of previous version.

Reported here: https://www.phpbb.com/community/viewtopic.php?p=13927351#p13927351

When you choose an option the option is lost while previewing the topic.

There may be users, who don't want their vote to be displayed for all others. They should have the chance to exclude their votes.

It needs to be considered to als add an option to deactivate this choice for specific polls, and maybe even a switch in ACP for admin to decide if the voters that don't want their vote to be shown should be fully hidden or listed with names below the votes.