wojtekboman / predictbom_backend

PredictBom_Backend

Web application created with React + Redux, Spring Boot, MongoDB technologies, enabling creation, management and participation in forecasting markets.
Live version: Try it
Frontend repository: Link

predictbom_backend's Issues

Enum ma metodę valueOf

PredictBom_Backend/src/main/java/com/example/PredictBom/Services/PredictionMarketService.java

Lines 104 to 119 in 9080885

	private MarketCategory getMarketCategory(String category) {
	switch (category) {
	case "SPORT":
	return MarketCategory.SPORT;
	case "ECONOMY":
	return MarketCategory.ECONOMY;
	case "CELEBRITIES":
	return MarketCategory.CELEBRITIES;
	case "POLICY":
	return MarketCategory.POLICY;
	case "OTHER":
	return MarketCategory.OTHER;
	default:
	return null;
	}
	}

https://stackoverflow.com/questions/604424/how-to-get-an-enum-value-from-a-string-value-in-java

Zła nazwa metody

PredictBom_Backend/src/main/java/com/example/PredictBom/Services/BuyingHelper.java

Lines 30 to 48 in 9080885

	default Contract findContractWithSamePrice(ContractRepository contractRepository, PredictionMarketRepository predictionMarketRepository, CounterService counterService, String username, int marketId, int betId, boolean option, int buyShares) {
	Optional<Contract> optionalContract = contractRepository.findByPlayerIdAndBetIdAndContractOption(username,betId,option);
	Contract contract;
	if(optionalContract.isPresent()){
	contract = optionalContract.get();
	contract.setShares(contract.getShares() + buyShares);
	contract.setModifiedDate(new SimpleDateFormat(SettingsParams.DATE_FORMAT, SettingsParams.LOCALE_PL).format(new Date()));
	contractRepository.update(contract);
	}else{
	Optional<PredictionMarket> optMarket = predictionMarketRepository.findByMarketId(marketId);
	if(!optMarket.isPresent()) return null;
	PredictionMarket market = optMarket.get();
	Set<Bet> bet = market.getBets().stream().filter(bet1 -> bet1.getId() == betId).collect(Collectors.toSet());
	MarketInfo marketInfo = MarketInfo.builder().topic(market.getTopic()).marketCover(market.getMarketCover()).marketCategory(market.getCategory()).build();
	contract = Contract.builder().id(counterService.getNextId("contracts")).bet(bet.iterator().next()).contractOption(option).shares(buyShares).marketInfo(marketInfo).playerId(username).build();
	contractRepository.save(contract);
	}
	return contract;
	}

Find sugeruje znalezienie/zwrócenie obiektu, a wykonywany jest update/save.

struktura kodu

PredictBom_Backend/src/main/java/com/example/PredictBom/Controllers/AuthController.java

Line 66 in 3f7fd58

Authentication authentication = authenticationManager.authenticate(

Logika biznesowa powinna być realizowane przez serwisy, proszę popatrzeć na ten artykuł z dobrymi praktykami:
https://www.e4developer.com/2018/08/06/spring-boot-best-practices/
warto kiedyś te dobre praktyki zastosować jeżeli ta aplikacja ma być w CV :-)
To nie jest pilne, na razie proponuję tego typu tematy zostawić na później bo teraz najważniejsze jest napisanie pracy.

Czy na pewno chcesz tu zwracać ResponseEntity lub null?

PredictBom_Backend/src/main/java/com/example/PredictBom/Services/BuyingHelper.java

Lines 17 to 28 in 9080885

	default ResponseEntity<?> checkBuyingLimit(TransactionRepository transactionRepository, String purchaser, int betId, boolean option, int shares) {
	GregorianCalendar cal = new GregorianCalendar();
	cal.setTime(new Date());
	cal.add(Calendar.DATE, -1);
	String date24hAgo = new SimpleDateFormat(SettingsParams.DATE_FORMAT, Locale.GERMANY).format(cal.getTime());
	List<Transaction> userTransactions = transactionRepository.findAllByPurchaserAndBetIdAndOptionInLast24hours(purchaser,betId,option,date24hAgo);
	int sumShares = userTransactions.stream().mapToInt(Transaction::getShares).sum();
	if(sumShares + shares > SettingsParams.LIMIT_PER_DAY) return ResponseEntity.badRequest().body("Przekroczyłeś dzienny limit zakupów akcji dla tej opcji zakładu. Możesz kupić "+ (SettingsParams.LIMIT_PER_DAY - sumShares) +" akcji");
	return null;
	}

Może tu nie powinno być zwracane ResponseEntity, tylko np. wartość limitu?

Za duża metoda, do rozbicia na mniejsze

PredictBom_Backend/src/main/java/com/example/PredictBom/Services/AuthService.java

Lines 72 to 125 in 9080885

	public ResponseEntity<?> signUp(SignupRequest signUpRequest) {
	if (userRepository.existsByUsername(signUpRequest.getUsername())) {
	return ResponseEntity
	.badRequest()
	.body(AuthConstants.USERNAME_ALREADY_USED_INFO);
	}
	if (userRepository.existsByEmail(signUpRequest.getEmail())) {
	return ResponseEntity
	.badRequest()
	.body(AuthConstants.EMAIL_ALREADY_USED_INFO);
	}
	User user = new User(signUpRequest.getUsername(), signUpRequest.getFirstName(), signUpRequest.getSurname(),
	signUpRequest.getEmail(),
	encoder.encode(signUpRequest.getPassword()));
	Set<String> strRoles = signUpRequest.getRoles();
	Set<Role> roles = new HashSet<>();
	//
	if (strRoles == null) {
	Role userRole = roleRepository.findByName(ERole.ROLE_PLAYER)
	.orElseThrow(() -> new RuntimeException(AuthConstants.ROLE_IS_NOT_FOUND_INFO));
	roles.add(userRole);
	Player player = new Player(signUpRequest.getUsername(), signUpRequest.getFirstName(), signUpRequest.getSurname(),
	signUpRequest.getEmail(),
	encoder.encode(signUpRequest.getPassword()), SettingsParams.START_BUDGET);
	player.setRoles(roles);
	playerRepository.save(player);
	return ResponseEntity.ok(AuthConstants.USER_SUCCESSFUL_REGISTERED);
	} else {
	strRoles.forEach(role -> {
	if ("mod".equals(role)) {
	Role modRole = roleRepository.findByName(ERole.ROLE_MODERATOR)
	.orElseThrow(() -> new RuntimeException(AuthConstants.ROLE_IS_NOT_FOUND_INFO));
	roles.add(modRole);
	} else {
	Role userRole = roleRepository.findByName(ERole.ROLE_PLAYER)
	.orElseThrow(() -> new RuntimeException(AuthConstants.ROLE_IS_NOT_FOUND_INFO));
	roles.add(userRole);
	}
	});
	}
	user.setRoles(roles);
	userRepository.save(user);
	return ResponseEntity.ok(AuthConstants.USER_SUCCESSFUL_REGISTERED);
	}

Rozważyłbym stworzenie ResponseFactory

PredictBom_Backend/src/main/java/com/example/PredictBom/Controllers/AuthController.java

Lines 48 to 58 in 9080885

	int result = authService.validatePasswordResetToken(token);
	switch (result) {
	case AuthConstants.CORRECT_TOKEN:
	return ResponseEntity.ok("Podano prawidłowy token");
	case AuthConstants.EXPIRED_TOKEN:
	return ResponseEntity.badRequest().body("Token wygasnął");
	case AuthConstants.INVALID_TOKEN:
	return ResponseEntity.badRequest().body("Nieprawidłowy token");
	default:
	return ResponseEntity.badRequest().body("Wystąpił błąd");
	}

Może warto, żeby authService.validatePasswordResetToken(token) było typu void i zwracało wyjątek, jeśli któryś z warunków nie zostanie spełniony. Wtedy w kontrolerze można zastosować factory do response i w kontrolerze zostałby:

try {
authService.validatePasswordResetToken(token);
return responseFactory.createSuccessResponse("Podano prawidłowy token");
} catch (Exception e) {
return responseFactory.createErrorResponse(e);
}