wnndgws / agendrum

Downloads Bing image of the day and overlays your calendar on it

About Me

Graphs provided from

agendrum's Issues

Consider using XDG_CONFIG_HOME

Here: https://github.com/WnndGws/wallpaperMaker/blob/fb291bd02d32062b14193de70cc1439965d005a5/get_calendar_events.py#L25-L27

check XDG_CONFIG_HOME
otherwise $HOME/.config

Not using env shebang

https://github.com/WnndGws/wallpaperMaker/blob/fb291bd02d32062b14193de70cc1439965d005a5/manipulate_image.py#L1

https://github.com/WnndGws/wallpaperMaker/blob/fb291bd02d32062b14193de70cc1439965d005a5/get_calendar_events.py#L1

https://github.com/WnndGws/wallpaperMaker/blob/fb291bd02d32062b14193de70cc1439965d005a5/download_wallpaper_image.py#L1

Use #!/usr/bin/env python instead. Also I think only the entry script (manipulate) needs it since the other ones are not run directly.

Bing country is hardcoded to Aus

https://github.com/WnndGws/wallpaperMaker/blob/fb291bd02d32062b14193de70cc1439965d005a5/download_wallpaper_image.py#L10

Make it configurable?

DRY: config location code basically duplicated

DRY

https://github.com/WnndGws/wallpaperMaker/blob/fb291bd02d32062b14193de70cc1439965d005a5/get_calendar_events.py#L41-L42

and

https://github.com/WnndGws/wallpaperMaker/blob/fb291bd02d32062b14193de70cc1439965d005a5/get_calendar_events.py#L25-L27

Since have a global variable, might as well make it reusable?

Allow user input

There is a lot of hard-coded variables in this script. Ideally would allow a config file or flags to allow user to choose their own options.

Would address:
#7
#8
#9
#13

Number of cal events hardcoded to 10

https://github.com/WnndGws/wallpaperMaker/blob/fb291bd02d32062b14193de70cc1439965d005a5/get_calendar_events.py#L59

Make it configurable? Some might only want 5.

It takes >1min to get all calendar events

This is much too slow. Possibly due to checking each calendar, thus making far too many API calls. Surely theres a way to make a single API call

Packaging

Make it so it can actually be pip installled. Then it could be packaged for AUR etc as well.

Entry point is weird

Weird that the entry point to the program is "manipulate image", sounds like some internal function rather than a command an end user would run. Shouldn't the main entry point basically be the name of the program?

Add screenshot to README

Use of CLIENT_SECRETS file not ideal

Since requires the use of the Google developer console to generate and download this file.

Use oauth flow instead? All access is read-only

Misleading name

Called "maker" but it goes as far as to set the wallpaper as well.

Why not leave that up to the user

Wallpaper resolution is hardcoded

https://github.com/WnndGws/wallpaperMaker/blob/fb291bd02d32062b14193de70cc1439965d005a5/download_wallpaper_image.py#L11

Make it configurable?

Change name to something other than "wallpaper maker"?

On top of being generic, the program itself is very specific: downloads from Bing, queries Google Calendar.

What about "Bing! Condom wallpaper"? (Not a real suggestion)

Can't provide own 'inspirational' quotes file

And the format isn't documented either