wlwanpan / minecraft-wrapper Goto Github PK

Dear author, I see that you have not updated in the last 2 years. Could you give me the library of snbt for maintenance? I am a novice, and I will try to adapt to the parsing of the lower version of snbt format

Currently, commands are being defined with functions that typically end up calling processCmdToEvent(Arr). As the functions are private methods, there are no options for commands to be defined for mods and datapacks in other packages while still using this package. A fork would be required.

Consider instead of defining a function for each command, define a struct fro each command that satisfies a Command interface which is passes to a Command function, which handles stringing the command to pass to the console, and reading/handling the events associated with that command. For example:

type Command interface {
	Command() string
	Events() []events.Event
}

type ExperienceAdd struct {
	Target string
	XP int32
	XPType ExperienceType
}

func (c ExperienceAdd) Command() string {
	return fmt.Sprintf(experience add %s &d %s, c.target, c.xp, c.xpType)
}

func (c ExperienceAdd) Events() []events.Event {
	return []events.Event{
		events.ExperienceAdd,
		events.NoPlayerFound.
	}
}

func (w *Wrapper) ExecuteCommand(c Command) error {
	ev, err := w.processCmdToEvent(c.Command(), time.Second, c.Events()...)
	if err != nil {
		return err
	}
	if ev.Is(events.NoPlayerFoundEvent) {
		return ErrPlayerNotFound
	}
	return nil
}

Please note this is not a real implementation, I just adapted the ExperienceAdd function to what it could look like in this Command interface format.

If this is an idea you are open to, I would be happy to work with you on a full implementation before switching from the current function approach.

Rn we need to look at the implementation logparser.go to figure out what Data each event holds. Might be worth having concrete event struct per events:

type PlayerJoinedEvent struct {
  Name string
  Time time.Time
  ...
}

type PlayerSayEvent struct {
  Name string
  Message string
  ...
}

then on the receiver side:

ev := <-wpr.GameEvents()
if ev.Type == events.PlayerSayEvent {
  playerSayEv := ev.(events.PlayerSayEvent)
}

Similar to https://github.com/wlwanpan/minecraft-wrapper/blob/master/wrapper.go#L280

https://minecraft.gamepedia.com/Commands/ban#ban-ip