wjlei1990 / seismo-sac_to_asdf_converter_2 Goto Github PK

1- I have two versions, one from James and one from Wenjie. James' version is a bit more simple and general. I guess, Wenjie modified James's routines for his purpose to be able to use ASDF files in FLEXWIN. Both of them seem to be working which is the good news.

2- I am assuming that Wenjie's version on Git repository is the latest one that I should be commenting on? Then, my major comment is that the version on Git repository in is too specific in its current form which is a temporary solution that Wenjie had to test FLEXWIN. It requires the presence of observed and synthetic seismograms, CMTSOLUTION, STATIONS files, period bands of seismograms, etc. However, a converter should be very general. What we need is just a converter that is able to convert any given SAC file into ASDF format regardless of observed or synthetic data and SAC headers must be carried to ASDF headers. There should not be any dependency to CMTSOLUTION or STATIONS files. The converter should not care if it is an observed or a synthetic seismogram, either. All additional information related to simulations, data processing info, etc. should be written into ASDF headers during pre-processing stage.

3- Please do not use any numbers or anything else to denote components of seismograms, like COMP_1, COMP_2, COMP_3, etc. anywhere rather than actual components such as Z, N, E, T, R, etc. for vertical, north-south, east-west, transverse, radial, etc., respectively. Otherwise it is very confusing to read or understand the code and/or outputs.

4- I think there should also be ASDF-to-SAC converter, a simple Fortran code that simply reads any ASDF file and writes out in SAC format. It is not urgent, though.