wix-incubator / wix-gruntfile Goto Github PK

Please remove or make public grunt-wix-inline

After the campaign of migration to monorepo bower components should be published to separate repo instead of a branch.
What steps should I perform to do this?

I've tried to set $GIT_REMOTE_URL like this:

"release": "[email protected]:wix-private/cashier-settings-component-bower-component.git node_modules/wix-gruntfile/scripts/release.sh"

but then bumped version became incorrect (starts from 1.0.1 again).

I've tried to use wnpm-release + bower-auto-release directly, but seems that bower-auto-release uses different steps and ignore/include patterns, and also incorrectly calculates new version.

Any tips how to migrate? @shahata

Hi. wix-gruntfile is currently #2 in my list of modules that would likely to be broken when nodejs/node#6413 lands (which is anticipated to happen before v7.0).

Note that graceful-fs@1 and graceful-fs@4 are ok and would not be broken by this, but a require() on graceful-fs@2 or graceful-fs@3 would cause an error soon.

That is, runtime warning fs: re-evaluating native module sources is not supported. would be turned into a throw.

If you or your deps use graceful-fs@2 or graceful-fs@3 in runtime — you are affected.

Tracking: nodejs/node#5213.

I think adding an initial test run to the serve task might be beneficial. This is what the config would look like:

grunt.registerTask('serve', function (target) {
    var jshint = grunt.config('jshint');
    jshint.options.force = true;
    grunt.config('jshint', jshint);

    if (target === 'dist') {
      return grunt.task.run(['connect:dist:keepalive']);
    }

    if (target === 'coverage') {
      var karma = grunt.config('karma');
      delete karma.unit.options.preprocessors;
      grunt.config('karma', karma);
    }

    grunt.task.run([
      'karma:unit',
      'pre-build',
      'karma:unit:run',
      'connect:livereload',
      'watch'
    ]);
  });

Note the karma:unit:runin the grunt.task.run block.

This doesn't stop the build if the tests don't pass or anything (which is how it should be, IMO), but it does run the tests so you can immediately see if something's wrong (as opposed to having to manually fake-edit a test/source file to see if tests pass, or cancelling out and running grunt test - both less than optimal).

No images are copied to debug, because there are no images with .js format.
Should have been:
{
expand: true,
cwd: '.tmp/images/',
src: ['__/.'],
dest: 'dist/debug/images'
}, {
expand: true,
cwd: 'app/images/',
src: ['__/.*'],
dest: 'dist/_debug/images'
}

instead of
{
expand: true,
cwd: '.tmp/images/',
src: ['/*.js'],
dest: 'dist/_debug/images'
}, {
expand: true,
cwd: 'app/images/',
src: ['/*.js'],
dest: 'dist/_debug/images'
}

Can we update the bower version in the package.json, or at least allow a higher version to be used?

You currently can't use this with the latest bower (1.3.3).

See: https://github.com/wix/wix-gruntfile/blob/master/package.json#L21

In fact, I'm not sure why a bower version even has to be specified in the peerDependencies.

What was the reason behind 5dfab3f ?

@shahata, should I revert it or make it configurable?

Installing latest version is unpossible because grunt-manifest-packager cannot be found.

Error log: https://gist.github.com/maxaon/7c1dff38579ba4e1416f