wirthual / deutschland-generator-action Goto Github PK

I am not sure if the allow empty commit is needed. I think it would be better or at least okay, that if there are no changes to the code that there is not a commit.

Maybe we can check for changes and if there are not any changes we can exit the action (maybe even with a success, so no failing).

See this line: https://github.com/wirthual/deutschland-generator-action/blob/main/action.yaml#L134

The action fails on rename generated code if the folder does not exist.
See Logs: https://github.com/lukaspanni/api-doc-template/runs/4657227598 at line 280 and following

Example

https://github.com/bundesAPI/nina-api/actions/runs/4324717600

I did some non-breaking basic changes to the Bundestag-API - repo.

During the PR the deutschland-generator-action runs: see here

Since there are no changes to the Python package the action returns an error during uploading to pypi:

25hWARNING  Error during upload. Retry with the --verbose option for more details. 
ERROR    HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/        
         Only one sdist may be uploaded per release.                            
Error: Process completed with exit code 1.

Should we check before uploading if during the runtime a new release has been created?

Or should we change the action itself. At the moment the action runs on every push see api-doc-template

I think the commit and the publishing to pypi should only run if the PR is merged (a push on the main branch).

What do you think @wirthual ?

Use the package name and version inputs in create_doc.
I will create a PR to fix this.