Coder Social home page Coder Social logo

wiris / moodle-tinymce_tiny_mce_wiris Goto Github PK

View Code? Open in Web Editor NEW
11.0 11.0 11.0 3.77 MB

TinyMCE's editor Moodle plugin for MathType, the leading formula editor and equation writer for the web by Wiris

Home Page: https://www.wiris.com/moodle

License: GNU General Public License v3.0

PHP 33.91% CSS 1.26% Gherkin 64.82%
chemistry maths mathtype moodle moodle-plugin tinymce wysiwyg

moodle-tinymce_tiny_mce_wiris's People

Contributors

carla-at-wiris avatar dcanet-at-wiris avatar diegowiris avatar hqiu-at-wiris avatar icaparros-at-wiris avatar jgonzalez-at-wiris avatar mcagigas-at-wiris avatar michaelmeneses avatar xripoll-at-wiris avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

moodle-tinymce_tiny_mce_wiris's Issues

Wiris filter attempts explicit path load of configurationjs.php, prevents TinyMCE editor from loading

Moodle: 3.9
Wiris: 7.26.0 2021050600

We have updated to Moodle 3.9 and Wiris 7.26.0 and have discovered that the TinyMCE editor no longer loads. We've discovered that Moodle is trying to fetch the file /filter/wiris/integration/configurationjs.php (with an explicit /filter/wiris/... path) which doesn't work on our instance as our Moodle is in a sub-directory.

The browser loads these files and other TinyMCE files fine,
/moodle3/lib/editor/tinymce/tiny_mce/3.5.11/tiny_mce.js
/moodle3/lib/editor/tinymce/tiny_mce/3.5.11/plugins/visualchars/editor_plugin.js

If I deliberately copy configurationjs.php onto the webserver into a directory were it is accessible as /filter/wiris/integration/configurationjs.php then the TinyMCE editor loads correctly.

I think Wiris' TinyMCE plugin contains an explicit path to /filter/wiris instead of filter/wiris

Conflict HTML sources editor

Hello, we use your plugin since a few month and we found a suspect behaiviour after an update.
We started by update the plugin from version 7.0.0.1386 to version 7.6.1.1393. No problem to insert equation or formula but when we want edit HTML source it's impossible to update content (through the HTML source editor pop-up). Same thing even if we have only "classic" HTML and no equation.

I suppose there was a bug because when I clicked on the "Update" button of the editor I saw the error below in my Chrome Console.

editor_plugin.src.js:322 Uncaught ReferenceError: Parse is not defined
    at Editor.eval (editor_plugin.src.js:322)
    at Dispatcher.dispatch (tiny_mce_src.js:561)
    at Editor.setContent (tiny_mce_src.js:14487)
    at saveContent (VM348 source_editor.js:5)
    at HTMLFormElement.onsubmit (VM353 source_editor.htm:1)

We have the same behaiviour and error after a new plugin update to the last version (7.7.0.1394) and this problem diseappear if we disable the plugin. I also tried to change some code but without success.

Regards.

chemistry and math buttons cause editor confusion

We have both the Chemistry button set and the Math button set available in our editors. In both tinymce and atto, if one of the editors is brought up, then closed, and the other button is pressed it will only change the title for the editor and not the button configurations. (for us chemistry set seems to take over)

To test:
open an editor and have the chemistry AND math set available
Click the chemistry set.
Verify the title and the button set are correct for the wiris editor.
Close the wiris popup.
Open the math set.
Verify the title is correct but the button set is still chemistry.

missing $string['privacy:metadata']

Got this message below when I ran vendor/bin/phpunit "provider_testcase" privacy/tests/provider_test.php

1) provider_testcase::test_null_provider with data set "tinymce_tiny_mce_wiris" ('tinymce_tiny_mce_wiris', 'tinymce_tiny_mce_wiris\privac...ovider')
Expectation failed, debugging() was triggered.
Debugging: Invalid get_string() identifier: 'privacy:metadata' or component 'tinymce_tiny_mce_wiris'. Perhaps you are missing $string['privacy:metadata'] = ''; in /siteroot/lib/editor/tinymce/plugins/tiny_mce_wiris/lang/en/tinymce_tiny_mce_wiris.php?
* line 353 of /lib/classes/string_manager_standard.php: call to debugging()
* line 7410 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
* line 90 of /privacy/tests/provider_test.php: call to get_string()
* line 1154 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to provider_testcase->test_null_provider()
* line 842 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to PHPUnit\Framework\TestCase->runTest()
* line 80 of /lib/phpunit/classes/advanced_testcase.php: call to PHPUnit\Framework\TestCase->runBare()
* line 693 of /vendor/phpunit/phpunit/src/Framework/TestResult.php: call to advanced_testcase->runBare()
* line 796 of /vendor/phpunit/phpunit/src/Framework/TestCase.php: call to PHPUnit\Framework\TestResult->run()
* line 746 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestCase->run()
* line 746 of /vendor/phpunit/phpunit/src/Framework/TestSuite.php: call to PHPUnit\Framework\TestSuite->run()
* line 652 of /vendor/phpunit/phpunit/src/TextUI/TestRunner.php: call to PHPUnit\Framework\TestSuite->run()
* line 206 of /vendor/phpunit/phpunit/src/TextUI/Command.php: call to PHPUnit\TextUI\TestRunner->doRun()
* line 162 of /vendor/phpunit/phpunit/src/TextUI/Command.php: call to PHPUnit\TextUI\Command->run()
* line 61 of /vendor/phpunit/phpunit/phpunit: call to PHPUnit\TextUI\Command::main()

Failed asserting that 1 matches expected 0.

/siteroot/lib/phpunit/classes/advanced_testcase.php:367
/siteroot/privacy/tests/provider_test.php:91
/siteroot/lib/phpunit/classes/advanced_testcase.php:80

To re-run:
 vendor/bin/phpunit "provider_testcase" privacy/tests/provider_test.php

Will send PR soon.

MathType for the new TinyMCE

This is not really an issue, but more of a question, please excuse me!

I am wondering if you have plans to offer a MathType for the new TinyMCE that became the default in Moodle 4.1?

Thank you in advance for any information you can offer on this topic!

Latest release may collide with other plugins

May be a variable collision...

Testing in Chrome.
Edit Moodle Page.
Click the wiris editor icon in the tinymce editor.
Receive the following editor in the browser console:

Uncaught ReferenceError: strings is not defined
at new ModalWindow (core.js:4097)
at wrs_openEditorWindow (core.js:2220)
at n._editorButton (yui_combo.php?m/1498738924/atto_panoptobutton/button/button-min.js&m/1498738924/atto_morefontcolors…:19)
at n._callbackWrapper (yui_combo.php?3.17.2/handlebars-compiler/handlebars-compiler-min.js&m/1498738924/core/handlebars/ha…:42)
at n. (yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:31)
at e.Subscriber.f.notifySub [as _notify] (yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:150)
at e.Subscriber.notify (yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:40)
at e.CustomEvent._notify (yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:39)
at e.CustomEvent._procSubs (yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:39)
at e.CustomEvent.fireSimple (yui_combo.php?rollup/3.17.2/yui-moodlesimple-min.js:39)

Parse is not defined

Hi, We use Moodle 3.4.5 (Build: 20180910) with filter_wiris (7.7.0.1394 2018100800), atto_wiris( 7.7.0.1394 2018100800) and tinymce_tiny_mce_wiris (7.7.0.1394 2018100800). When edit a page and want to user editor on full sceen.
screen shot 2018-10-16 at 3 16 25 pm
Editor opens on full screen without problem. But, once he decides to go back and he reclicks on :
screen shot 2018-10-16 at 3 17 18 pm
He cannot closes fullscreen mode. On console we have this error :
editor_plugin.src.js:322 Uncaught ReferenceError: Parse is not defined at Editor.eval (editor_plugin.src.js:322) at Dispatcher.dispatch (tiny_mce_src.js:561) at Editor.setContent (tiny_mce_src.js:14487) at transferState (editor_plugin_src.js:28) at p.(/~cimo1901/moodle/course/anonymous function).t.saveState (https://www.usherbrooke.ca/~cimo1901/moodle/lib/editor/tinymce/tiny_mce/3.5.11/plugins/fullscreen/editor_plugin_src.js:194:5) at editor_plugin_src.js:55

at this line params.content = Parse.initParse(params.content, editor.getParam('language'));

We have another intances that uses same moodle version but versions (7.5.0.1391 2018080300) of wiris plugins and we doesn't have any error.

For tests purposes on instances that had error I remove wiris plugins and tinymce worked without problem.

Thanks in advance for any help.

undefined strings

Latest version, I'm seeing undefined window modal title and button text.
capture

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.