winipcfg / libfov Goto Github PK

What version of the product are you using? On what operating system?

I have downloaded the latest version of libfov (1.0.4) and am using it on 
32-bit linux (2.6.34).

Please provide any additional information below.

While using a beam for shadow-casting it seems that the beam is always oriented 
in one of the eight cardinal directions. How can I specify that the beam angle 
is say 120 degrees and it is oriented at 30 degrees from North?

libfov cannot be build from outside the source tree, because the library is 
looked for in srcdir (instead of builddir) when linking `tests` and `examples`. 
Doxygen also has issues.

I have attached a patch.

Note: docs/Doxyfile must be moved to docs/Doxyfile.in before applying.

Demo for coloured lights and light mixing.

Demo where lights flicker or change in real time.

Where to host it?

Obdur, torch gifs, Temple of Zum.

Put them on the wiki.

if (angle <= 0.0f) {
  return;
} else if (angle >= 360.0f) {
  _fov_circle(&data);
}

i think it should be this:

if (angle <= 0.0f) {
  return;
} else if (angle >= 360.0f) {
  _fov_circle(&data);
  return;
}

Implement a boolean flag that controls whether a light source "peeks"
around adjacent corners.

Allow the user to define from what point in a tile the light source eminates.

Include Visual C++ project files in the repository to boostrap VC++ users.

Add Valgrind build tasks and fix any problems

I can't remember whether it's dx or dy or what octant it is, but put a test
in for all of them.

Currently there is 1 demo and it uses SDL. Make it use ncurses for people
who are targeting ncurses because they won't necessarily have or want SDL
installed.

Vagrind reported this:
==29143== Conditional jump or move depends on uninitialised value(s)
==29143== at 0x80C21D0: fov_settings_free (fov.c:163)

I noticed that the the fov_settings_free() is comparing the value of
settings->heights, and it has not been initialized in the
fov_settings_init() to it causes Valgrind to report it. Simple fix is to
initialize it to NULL in the fov_settings_init():

--- fov.c (revision ??)
+++ fov.c (working copy)
@@ -81,6 +81,7 @@
settings->opaque_apply = FOV_OPAQUE_APPLY;
settings->opaque = NULL;
settings->apply = NULL;
+ settings->heights = NULL;
settings->numheights = 0;
}

This bug is not visible to users, as on the same line settings->numheights
value is compared, which makes the function work correctly. But it would be
nice to fix this to cleanup the Valgrind output to see the real problems.