wingle / mocean-sdk-ios Goto Github PK

What steps will reproduce the problem?
1. Create test ad with a frame height > 100 and setContentAlignment to YES.
2. When frame has a larger height than the ad, ad shows top aligned, instead of 
centered.

What is the expected output? What do you see instead?
The ad should appear vertically aligned when frame is larger.

What version of the product are you using? On what operating system?
iOS 5, iPad.

Please provide any additional information below.
Fix is easy:

In AdDescriptHelper.m change table height from 'device-height' to '100%'. 
Attached patch.

What steps will reproduce the problem?
1. Tried to set [adView showPreviousAdOnError:NO];
2. Run the app, crash!

What is the expected output? What do you see instead?
Not crashing

What version of the product are you using? On what operating system?
2.10.0 SDK on iPad iOS 5.0

Please provide any additional information below.

Getting this crash log:
2012-03-02 12:04:58.381 HopStop for iPad[1345:707] -[MASTAdView 
showPreviousAdOnError:]: unrecognized selector sent to instance 0x38a250
2012-03-02 12:04:58.383 HopStop for iPad[1345:707] *** Terminating app due to 
uncaught exception 'NSInvalidArgumentException', reason: '-[MASTAdView 
showPreviousAdOnError:]: unrecognized selector sent to instance 0x38a250'

What steps will reproduce the problem?
1. Run sample
2. Tap 'Rich Media' 
3. Banner image is displayed at half size

What is the expected output? What do you see instead?
Banner image to display at full size. Fill the whole ad view.

What version of the product are you using? On what operating system?
SDK 2.11. iOS 5. Simulator and device

Please provide any additional information below.

What steps will reproduce the problem?
1. create ad/call update
2. perform uiview manipulation in willReceiveAd: 
3. nothing happens, or action is delayed

What is the expected output? What do you see instead?
it appears this function is being called from a thread outside the main thread. 
This should be indicated in the documentation.

What version of the product are you using? On what operating system?
https://code.google.com/p/mocean-sdk-ios/@8229ffc62abfede7383abde1bb4ec5c0349f8f
13 

Please provide any additional information below.

What steps will reproduce the problem?
1. Run analyze on a project that uses the AdMobile SDK

What is the expected output? What do you see instead?

There should be no warnings about memory errors in the file 
ServerXMLResponseParser.m

Instead of this there are a large number of warnings and examining the code 
indicates various memory management mistakes that could lead to an application 
crash.


What version of the product are you using? On what operating system?

Version 2.8.0

Please provide any additional information below.

This is an example of code that is incorrect. The release calls are not 
necessary as the property is being set to nil which will release the object.

    [self.campaignId release];
    self.campaignId = nil;
    [self.trackUrl release];
    self.trackUrl = nil;
    [self.appId release];
    self.appId = nil;
    [self.adId release];
    self.adId = nil;
    [self.adType release];
    self.adType = nil;
    [self.latitude release];
    self.latitude = nil;
    [self.longitude release];
    self.longitude = nil;
   [self.zip release];
    self.zip = nil;

What steps will reproduce the problem?
1. Start the app on landscape
2. Rotate to portrait
3. Tap on Ad
4. Try tapping on Done Button, it won't work. You need to rotate again to 
landscape for it to work.

What is the expected output? What do you see instead?
Tapping on Done Button should always work

What version of the product are you using? On what operating system?
2.9.0 on IOS 5, ipad

Please provide any additional information below.

OrmmaAdaptor.m, line 415 has:
  ekEvent.endDate   = [[NSDate alloc] initWithTimeInterval:600 sinceDate:ekEvent.startDate];
and should be
  ekEvent.endDate   = [[[NSDate alloc] initWithTimeInterval:600 sinceDate:ekEvent.startDate] autorelease];
After all, endDate is a property with copy attribute.

What steps will reproduce the problem?
1. Configure a zone with a few ad creatives with transparent images, different 
enough that when stacked on top of each other, the others show through the 
transparent areas.
2. Set animateMode = NO to turn off animations on the ad.
3. Make multiple ad requests using the same ad instance and the zone created in 
step 1 above.

What is the expected output? What do you see instead?
Expect the previous ad to be cleared when showing a new ad.  Instead, the 
previous ads are not cleared and the ads stack one on top of the other, with 
the lower ads showing through the transparent areas of the ones above them.

What version of the product are you using? On what operating system?
Reproduced in iOS SDK 2.5.0 and 2.5.2.

Please provide any additional information below.

I fixed the issue in our copy of the source code by adding the following to the 
AdView displayAd method below the "subView.hidden = NO;" line:

            // If we aren't animating then the previous ad isn't moved out of view and if the ad on top
            // has transparent areas then the previous ad shows through.
            if (!model.animateMode && currentAdView)
            {
                currentAdView.hidden = YES;
            }

What steps will reproduce the problem?
1. Set a UITabViewController, each will have a MASTAdView
2. Set [MASTAdView setLocationDetectionEnabled:YES]; when creating the ad.

What is the expected output? What do you see instead?
Always pass lat, long. What I see is that lat=, long= are only being passed on 
the first tab that updated the ad after getting the location: (this is the 
message in the log).

Ad  - Location Manager Location Update - <+40.xxxx,-73.xxxx> +/- 

I think that this is due to that it only gets the latitude, longitude values 
once (when listening for device location updates) and sets them. But the other 
tabs won't be able to get this location update and thus will never pass 
latitude nor longitude.
The previous SDK worked well with this scenario. 

Another thing is that it used to call update when a new location was found, 
this new version of the SDK does not.

What version of the product are you using? On what operating system?
SDK 2.11.0, iOS SDK 5.1, tested on iPad 1 running ios 5.1

Please provide any additional information below.

What steps will reproduce the problem?
1. Import library.
2. There might be overlap with commonly used names for certain classes such as 
LocationManager
3. Xcode complains, or app breaks.

What is the expected output? What do you see instead?
Name files and libraries using prefixes, such as MOCLocationManager or 
MOCAdView in order to avoid conflicts.

What version of the product are you using? On what operating system?
2.8.0

Please provide any additional information below.
Here is a link with prefixes already being used: 
http://www.cocoadev.com/index.pl?ChooseYourOwnPrefix
It is ideal to have prefixes, other commonly used libraries such as Google 
Analytics has a GAN prefix.

What steps will reproduce the problem?
1. Debug an app using the SDK on an iPhone.
2. Look at the log statements for the carrier parameter.
3.

What is the expected output? What do you see instead?
Carrier is automatically set to the device's carrier.  Carrier is blank or 
missing.

What version of the product are you using? On what operating system?
iOS SDK 2.5.0.

Please provide any additional information below.
It clearly states on this page that this is one of properties the SDK fills in 
automatically:

http://developer.moceanmobile.com/SDK-API_Calls