william9923 / duelfx

A trading card game built using javafx to learn OOP in medium sized application.

Hey! I'm William

Finding the right time for my mega evolution!

About Me:

• Pardon my github stats, been using Gitlab for works nowadays :D
• For first 3 month of 2024, will be focusing on 3 main things:
  1. Improving personal technical writing
  2. Learning more network & infra-related stuff (mostly concepts => then implemented on GCP)
  3. Improving effective communication with fellow engineer & non-engineer
• Currently working as Software Engineer (Platform) at Gojek (a ride hriling app), mainly working on improving order allocation by increasing the reliability and building tools for better experience on onboarding new business requirements.
• Some facts about me (for work):
  1. Mainly working with Golang, Lua, Python.
  2. Using Postgresql, Etcd, and redis for the datastore
  3. For the infra, we use GKE (GCP) for the kubernetes cluster, version controlled using terraform (IaC tools).
  4. Still somewhat familiar with things that I had been working in the past (like Java, MySQL, etc...)
• Few books that I've been reading for some time (helpful when my company provide physical library books :D):
  1. Software Design by Example
  2. Terraform Up and Running (3rd Edition)
  3. Managing Kubernetes
  4. Building Microservice
  5. Release It!: Design and Deploy Production-Ready Software
• My main hobby is improving (mostly just tweaking) my neovim configs, reading open source projects that I use in work, exploring random stuff, going to gym (just enough to not get backpain lol), and watching anime
• Feel free to reach me about anything via linkedin or by email

Familiar Tech Stack:

My Personal Neovim Configs:

Second Iteration:

First Iteration:

My Stats:

Open Source Contribution

🎁 Projects	⭐ Stars	📚 Forks	🛎 Issues	📬 Pull requests	💼 Role
RedditVideoMakerBot

duelfx's Issues

Display?

I don't really know the purpose of this Display class, but usually using Map is a bad idea. For example, how do you ensure that the key "attack" is exist? What's the difference between using Map and class anyway?

This issue is only a suggestion. You may ignore it (not all the suggestions are true), challenge it, or come up with another idea yourself.

https://github.com/William9923/CardGameOOP/blob/ee9e38829f60bac28c7a75d2b64b9b6a1de7d3e9/src/main/java/com/avatarduel/display/IDisplay.java#L6-L12

Multiple constructor based on parameter length

I think this is a bad idea. What if in the future, the cards get more additional properties and all types of card has the same 9 properties? How about we use 3 class instead of only one class?

This issue is only a suggestion. You may ignore it (not all the suggestions are true), challenge it, or come up with another idea yourself.

https://github.com/William9923/CardGameOOP/blob/70c0e24587f12251eb4bca872411622191656b47/src/main/java/com/avatarduel/model/SkillCard.java#L14-L36

Refactoring Action into Event

Btw, usually we use Event, because "command" and "action" is too specific. For example, isn't it weird if someday you have MouseEnterCardAction or PlayerDiedAction? Instead it wll be more make sense if you use "Event". Moreover, this is common pattern on Publish/Subscribe pattern.

https://github.com/William9923/CardGameOOP/blob/7932d1b4dd12490bae416b7f6823177b7e245b22/src/main/java/com/avatarduel/command/IAction.java#L5-L8

This issue is only a suggestion. You may argue with it (not all the suggestions are true), challenge it, or come up with another idea yourself.

Extend List instead of composing list

This Hand and Deck is basically a list of Card. Some methods like contain, getSize, etc have already been defined in Java List Interface. Why don't we create class Hand extends ArrayList instead?

https://github.com/William9923/CardGameOOP/blob/2fc745ec072ade073f5a9d2a06789045347dff5e/src/main/java/com/avatarduel/model/Hand.java#L7-L22

https://github.com/William9923/CardGameOOP/blob/2fc745ec072ade073f5a9d2a06789045347dff5e/src/main/java/com/avatarduel/model/Deck.java#L7-L20

This issue is only a suggestion. You may ignore it (not all the suggestions are true), challenge it, or come up with another idea yourself.

Update gitignore

Some of the binary files are included on git files. Try to remove it with git rm

https://github.com/William9923/CardGameOOP/blob/70c0e24587f12251eb4bca872411622191656b47/.gitignore#L1-L52