wildhaber / gohugo-amp Goto Github PK

Would it be possible to have the code on the exampleSite folder be updated with the documentation site's code.

That would be really helpful to try it out.

I'm trying to get the simple quickstart site to work.

I posted here on the Hugo forum.

I'm missing something obvious I think. Any suggestions on why I can't just render the basic quickstart single page site would be appreciated!

Hi, I get this error when I use the files from the example folder:
hugo server -D
Started building sites ...
ERROR 2017/08/14 03:01:42 Error while rendering "page": template: theme/_default/single.html:1:3: executing "theme/_default/single.html" at <partial "structure/h...>: error calling partial: template: theme/partials/structure/head.html:12:7: executing "theme/partials/structure/head.html" at <partial "amp/header"...>: error calling partial: template: theme/partials/amp/header.html:4:16: executing "theme/partials/amp/header.html" at <index (index $.Site....>: error calling index: index of untyped nil

I am using Hugo version v0.20.7 darwin/amd64 BuildDate: 2017-05-17T00:59:06+02:00

It would be helpful to see how you added some of the feature to demo site. For example how you added the amp header, sidebar, and breadcrumbs.

When installing:

rm -rf gohugo-amp/.git
'rm' is not recognized as an internal or external command,
operable program or batch file.

hi,
i'm looping around the partial,
but i'm not able to understand what activate the upper menu.

i would that if i have some folders,

/a
/b

and so on, the upper menu will show me those menu.

can someone help me please?

thaks

Google page speed shows the issue to reduce the "above the fold" html elements:

https://developers.google.com/speed/pagespeed/insights/?url=https%3A%2F%2Fgohugo-amp.gohugohq.com%2Fkitchen-sink%2F&tab=desktop

Looks like the parameters with upper-case characters don't recognition with 'isset' function.

For example, config.toml has parameter
googleAnalytics = "UA-12345678-123"
But I get the message 'You must set a googleAnalytics UA-Code within the global config.toml Params.' on the page.

I've made a changes in the file themes\gohugo-amp\layouts\partials\amp\google-analytics.html:
from
{{ if isset $.Site.Params "googleAnalytics" }}
to
{{ if isset $.Site.Params "googleanalytics" }}
and everything is working now.

But the strings:
{{ printf "%s" $.Site.Params.googleAnalytics }}
{{ printf "%s" $.Site.Params.googleanalytics }}
work both.

The same problem in the file 'app-banner-header.html' and others.

i would like to make an amp version of my website while still using my theme's design(for consistency), is there a way to do this?
I am using Novela by Foresrty/The New Dynamic

I notice that most of your shortcode example use {{% (will render inner content as markdown) and not what I believe is a better fit: {{<

Also, Hugo supports "commented out" Shortcodes, so instead of:

{\{% partial "test/lipsum" %}\}

You wan write:

{{%/* partial "test/lipsum" */%}}

Hi

Since I am already using a theme that is based on Bootstrap, AMP integration isn't possible with it.
Can we use GoHugo AMP such that two themes can generate two html files (one Desktop and another Mobile) so that AMP along with normal website could be possible.

Hi
thanks for your awesome theme.

evaluating your theme with google pagespeed insight, i obtain a result that maybe be improved.

please, open https://developers.google.com/speed/pagespeed/insights/?hl=it&url=https%3A%2F%2Fgohugo-amp.gohugohq.com%2F&tab=mobile and wait until test is done.

there are only one things the theme can do : give priority to visible contents.

other problems as servercachetime, image optimization and server response time are not theme problem.

hello

I've added the settings given to the config file and added the theme to the name of the config file, but the homepage looks only white and no content appears.

my website https://www.vayba.com

web server firebase

GoHugo AMP is really a brilliant theme one can use. You guys are doing great job with this. However, I am currently using a theme for regular website and want to implement AMP on my website using this theme.

Since I can only use a single configuration file, I would like to request you to please help me by letting me know who can I use this theme along with a regular theme.

Thanks in advance.

Hi,
Thanks for this theme! Using your default code for from: https://github.com/wildhaber/gohugo-amp/blob/develop/layouts/partials/seo/structured/breadcrumb.html when add it to my site and visit any page, position 2 and other positions show the URL twice?

<script type="application/ld+json">
{
  "@context": "http://schema.org",
  "@type": "BreadcrumbList",
  "itemListElement": [{
        "@type": "ListItem",
        "position": 1,
        "item": {
          "@id": "http://localhost:1313/",
          "name": "home"
        }
    },{
        "@type": "ListItem",
        "position": 2,
        "item": {
          "@id": "http://localhost:1313/reviews/http://localhost:1313/reviews/",
          "name": "reviews"
        }
    }]
}
</script>

E.g.
http://localhost:1313/reviews/http://localhost:1313/reviews/

I pulled the code at:
https://github.com/wildhaber/gohugo-amp.gohugohq.com

Then checked out the "develop" branch and kicked it off using "npm run go".
It runs, but only the first page works on localhost:1313
All other pages like "http://localhost:1313/install/" get a 404.
Not sure what i am doing wrong.... ??

Sorry about this. Must be something simple i am not getting ?

my make script:

LIB=github.com/wildhaber/gohugo-amp.gohugohq.com
LIB_FSPATH=$(GOPATH)/src/$(LIB)

## install on gopath and run
go get -u $(LIB)/...
cd $(LIB_FSPATH) && git checkout develop
cd $(LIB_FSPATH) && yarn install 
cd $(LIB_FSPATH) && npm run go

output:

cd /Users/apple/workspace/go/src/github.com/wildhaber/gohugo-amp.gohugohq.com && npm run go

> [email protected] go /Users/apple/workspace/go/src/github.com/wildhaber/gohugo-amp.gohugohq.com
> npm run hugo:server


> [email protected] hugo:server /Users/apple/workspace/go/src/github.com/wildhaber/gohugo-amp.gohugohq.com
> hugo server --buildDrafts --buildFuture


                   | EN
+------------------+----+
  Pages            | 88
  Paginator pages  |  0
  Non-page files   |  0
  Static files     | 11
  Processed images |  0
  Aliases          |  0
  Sitemaps         |  1
  Cleaned          |  0

Total in 70 ms
Watching for changes in /Users/apple/workspace/go/src/github.com/wildhaber/gohugo-amp.gohugohq.com/{content,data,i18n,layouts,static,themes}
Watching for config changes in /Users/apple/workspace/go/src/github.com/wildhaber/gohugo-amp.gohugohq.com/config.toml
Environment: "development"
Serving pages from memory
Running in Fast Render Mode. For full rebuilds on change: hugo server --disableFastRender
Web Server is available at http://localhost:1313/ (bind address 127.0.0.1)
Press Ctrl+C to stop

Hi there,

Thanks for writing this awesome theme, it's really good. but I got one question might need you guys help. I'm trying to override the variable .Params.amp.elements on my single.html. the reason why I want to do this is because every single page have the component amp-addthis, so add it to single.html might good than add it in every single.md or archetypes/article.md.

So far I tried {{ .Params.amp.elements = ["amp-addthis"] }} and {{ .Params.amp.elements := ["amp-addthis"] }} both will throw an error: unexpected "=" in operand.

If anyone know how to override or append a new element into the amp.elements please let me know.

Really thanks for you guys work. 👍

In https://gohugo-amp.gohugohq.com/install/ page, kitchen sink text is linked to 404 page.

Current URL: https://gohugo-amp.gohugohq.com/ktichen-sink/
Expected URL: https://gohugo-amp.gohugohq.com/kitchen-sink/

Is there anything special i need to do to provide multi-language content.