widoz / wp-entities-search Goto Github PK

Currently the only way to retrieve the state and the dispatch is to use the useEntitiesOptionsStorage hook, but that would mean that if I have to consume one of the two mentioned above I have to pass them and that requires additional parameters we can avoid if we allow the components and other hooks to access the state and dispatch directly by calling useEntitiesOptionsStorage.

The Yarn lock file seems to be Yarn2, but Yarn2 needs Nodejs 18.

Usage Error: This tool requires a Node version compatible with >=18.12.0 (got 16.20.2).

💥 What to do now?

Values within the change event handlers is a string but we would like to keep the type if possible.

Introduce styles for the built in controls, maybe producing something with more appealing for the end user.

When the selected post is deselected, even thought it would appear as part of the current options it does not.

The id is based on the label and the value but we might have multiple instances of the components rendering the same options in the same page.

We need a better way.

One or more posts stored somewhere might no longer be available.

Ideally you would be informed about this case.

An idea is to add custom styles via a flag property for each of the posts that no longer exists.

See how's possible to perform this at once when the posts options list is retrieved rather than making an additional request to the server.

Do not forget the REST Response is merged with the hardcoded options.

Not all class names for the components start with wp-entities-search-.

• Configure Eslint
• Export to a new generic package for re-usage reasons
• Introduce Logging
• Optimize Build
• Do not forget Package License
• Allow to run the assets compilation manually? If so, how to deal with the tag creation?
• Add @WordPress eslint rules?
• Use prettier for grouping imports or?
• Add Array type consistency via eslint
• Solve Husky issue which is running during non github actions changes

To have more control over the search logic in the Server. Right now we rely on the search end point

We want to include informations in a formatted pleasant way

• Entity Title
• Thumbnail
• Excerpt / Truncate Content
• Date?
• ... what else?

The project does not have psalm configuration

The attachment is not considered a valid CTP for the search Endpoint

The action UPDATE_CONTEXTUAL_ENTITIES_OPTIONS just store a value which is never read again. The contextualEntitiesOptions indeed seems not to be consumed.

The option.value might have spaces or characters which are not allowed in a class attribute. Also, not sure if all option.labels are slugified.

Use slugifyOptionLabel

The styles from the @wordpress/scripts package are not applied. It might be because of the prettier dependency or some configuration. Maybe related to .editorconfig not sure.

Main problems are spacings.

• Update to node 20
• Install the peer dependencies missed

➤ YN0060: │ react is listed by your project with version 18.2.0, which doesn't satisfy what @wordpress/components (p1eae0) and other dependencies request (but they have non-overlapping ranges!).
➤ YN0002: │ wp-entities-search@workspace:. doesn't provide @babel/core (p6481a), requested by @wordpress/eslint-plugin.
➤ YN0002: │ wp-entities-search@workspace:. doesn't provide @playwright/test (pe303c), requested by @wordpress/scripts.
➤ YN0002: │ wp-entities-search@workspace:. doesn't provide @types/node (pf38a4), requested by ts-node.
➤ YN0002: │ wp-entities-search@workspace:. doesn't provide eslint (p6a31a), requested by @wordpress/eslint-plugin.
➤ YN0002: │ wp-entities-search@workspace:. doesn't provide eslint (p7cd0e), requested by eslint-import-resolver-typescript.
➤ YN0002: │ wp-entities-search@workspace:. doesn't provide eslint-plugin-import (p4bf4d), requested by eslint-import-resolver-typescript.
➤ YN0002: │ wp-entities-search@workspace:. doesn't provide react-dom (p55682), requested by @wordpress/components.
➤ YN0002: │ wp-entities-search@workspace:. doesn't provide react-dom (p690a8), requested by @wordpress/scripts.
➤ YN0002: │ wp-entities-search@workspace:. doesn't provide react-dom (p9d909), requested by @testing-library/react.
➤ YN0002: │ wp-entities-search@workspace:. doesn't provide webpack (p192f6), requested by @wordpress/dependency-extraction-webpack-plugin.
➤ YN0002: │ wp-entities-search@workspace:. doesn't provide webpack (paf466), requested by ts-loader.

We want to make the kind searchable rather then presenting a predefined list.

The Set Data Structure shall contain unique values even if them are objects.