whmcs / sample-registrar-module Goto Github PK

Comparable to #8, just for function CheckAvailability.

Cloning into 'sample-registrar-module'...
[email protected]: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Function registrarmodule_GetDomainSuggestions must return an instance of \WHMCS\Domains\DomainLookup\ResultsList

Stack Trace:

InvalidArgumentException: Return must be an instance of \WHMCS\Domains\DomainLookup\ResultsList in /var/www/whmcs/vendor/whmcs/whmcs-foundation/lib/Domains/DomainLookup/Provider/AbstractProvider.php:0
Stack trace:
#0 /var/www/whmcs/admin/whois.php(0): WHMCS\Domains\DomainLookup\Provider\AbstractProvider->getSuggestions()
#1 {main}

There is no consistency on when return 'success' => true or 'success' => 'success' . I suspect that the backend is evaluating success index as a boolean and therefore the string 'success' is true. Otherwise, what we should return when 'success' is false in the cases where we are returning a string?

'success' => 'success' (9)

'success' => true (7)

I know this repository is bit old, but since then Github created the option to mark "repository as a template". With this feature, developers can fork the project not being a fork but as a template:

Check this URL: https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/creating-a-template-repository

This feature would be cool on this repository.

Hello,

I wish to write a registrar module.

I Cloned the repo,
Renamed the module directory and file.
Replaced all occurrences of registrarmodule_ with the new name.
Uploaded the directory and activated the module.

When trying to edit configuration information, the information can't be saved.

Description

registrarmodule_GetNameservers is returning 'success' => true' and then the Client Area is interpreting that as another Nameserver.

Admin Area

Client Area

If a previously created A record is deleted via the API, recreating a new one always produces a "Duplicate host record" when trying to recreate the record. I have verified that the record does not exist by listing all the A records first, before issuing the POST.

As far as I can tell, there there is no update option (even if you specify the RecordId during the POST), so I thought it would be best to first delete all the records, then add all the updated records from the DNS Management form. Despite the error, the records still get created.

I posted an earlier Issue that relates to this but for some reason my issue was removed. I would appreciate knowing why.

Enter in megabytes should be something like Enter username or email address and the default value should be something like username.

Hi,

I'm developing some modules for WHMCS and I noticed some inconsistency behaviour using WHMCS\Domains\DomainLookup\SearchResult::STATUS_UNKNOWN.

When I Check Availability from Client Area (through CheckAvailability function), if I return STATUS_UNKNOWN, Client Area says that that domain is unavailable:

However, in suggested domains, when that domain shows up to be checked (consequently to call CheckAvailability function again), if I return STATUS_UNKNOWN, it allows me to add to the cart:

Conclusion: When I return STATUS_UNKNOWN for a domain, I can't register it through the regular way but I CAN register it through suggested domains.

I don't know if I'm missing something... Can someone clarify this?

Thank you.