whitewolfza / puz Goto Github PK

Got this to build on Windows.  Wanted to document the changes it required just 
in case anyone has a need for this.  It does not compile for Windows without 
modification.

Added the following files to the build since Windows doesn't offer memory 
mapping:
http://code.google.com/p/mman-win32/source/browse/trunk/mman.h
http://code.google.com/p/mman-win32/source/browse/trunk/mman.c

Windows is also missing a strndup function, so I added the code for a version I 
wrote to the build:
#include <string.h>
#include <stdlib.h>

char *strndup (const char *s, size_t size)
{
   int sz = strlen (s); 
   if (sz > size)
      sz = size;
   char *retval = (char *) malloc (sz + 1);
   {
      memcpy( retval, s, sz);
      retval[sz] = '\0';
   }
   return (retval);
}

Once those are added to the Win32 build, it builds fine on Windows using 
MinGW32.  Was able to get readpuz.exe to execute on a Windows system.

What steps will reproduce the problem?
1. read in any text-format puzzle files

The clues appear in the wrong order and the notes section is ignored.

What steps will reproduce the problem?
1. Create test.txt, a text puz file
2. readpuz test.txt test.puz
3.

What is the expected output? 
A binary puz file, created from test.txt

What do you see instead?
A segfault

What version of the product are you using? 
libpuz-1.1.0

On what operating system?
linux

Please provide any additional information below.

I ran gdb and found that I was dying in cksum.c, in reading puz->notes.  I 
found that puz->notes is initialized in load.c/puz_load_bin, when a binary puz 
file is read in, but couldn't find where it was getting initialized when 
reading a text puz file.

I got my conversion to work by commenting out all mention of pux->notes in 
cksum.c.  This is obviously not a viable solution for general use.

My svn checkout of puz-read-only (from today) does not have the crossword.js 
file needed by crossword.html.

I was searching info about this format when I found both your project, and
the info from LitSoft. I hope this will be useful.

http://www.litsoft.com/across/alite/man/AcrossTextFormat.pdf

Cheers,
David.