whipdevelopment / crashclaim Goto Github PK

When you try to resize, specifically expanding a claim, it does absolutely nothing.

I'm looking into this, and the code I think that is causing this issue is in ClaimDataManager.java where a new ConfirmationMenu is created, but the BiFunction is not running strangely? Thus it does not get processed properly.

Trying to fix it on a fork myself, but hoping if anyone else can replicate the issue or find a fix.

EDIT: Should also note, that I am using the CrashClaimEconomy addon as well

By default users cannot hit/kill entities in other player's claims, this causes an issue due to the entities still being able to kill the players. My suggestion is to have the Entity flag to be enabled by default.

Hi, with crashclaims 1.0.39 on a 1.20 paper server players are able to attack each other and attack pets/villagers/entitites while in other players claims. any idea whats causing this? im getting zero errors in the config.

The server decides to close itself as soon as it loads the plugin. Any other version nor fix wont help, It doesnt give a command history output when crashes, but as i observed it also doesnt give any errors.

Players regardless of claim settings are able to spawn mobs using mob spawn eggs, thus resulting in possible griefing.

When a user is flying with an elytra, if they enter a claim that has the "Entities" flag disabled, they cannot fire off a firework rocket to continue flying.

Hello,

I just bought Crashclaim and when i restart my server it says

[[[[Server thread/ERROR]: Error occurred while enabling CrashClaim v1.0.14 (Is it up to date?)
java.lang.NoSuchMethodError: org.bukkit.inventory.meta.ItemMeta.setLoreComponents(Ljava/util/List;)V
at net.crashcraft.crashclaim.localization.Localization$ItemStackTemplate.build(Localization.java:707) ~[?:?]
at net.crashcraft.crashclaim.localization.Localization$ItemStackTemplate.(Localization.java:668) ~[?:?]
at net.crashcraft.crashclaim.localization.Localization.(Localization.java:589) ~[?:?]
at net.crashcraft.crashclaim.localization.Localization.(Localization.java:51) ~[?:?]
at net.crashcraft.crashclaim.localization.LocalizationLoader.initialize(LocalizationLoader.java:31) ~[?:?]
at net.crashcraft.crashclaim.CrashClaim.onEnable(CrashClaim.java:90) ~[?:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:263) ~[spigot-1.16.4.jar:git-Spigot-a93cbb1-7a6c3c9]
at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:351) ~[spigot-1.16.4.jar:git-Spigot-a93cbb1-7a6c3c9]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:480) ~[spigot-1.16.4.jar:git-Spigot-a93cbb1-7a6c3c9]
at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugin(CraftServer.java:494) ~[spigot-1.16.4.jar:git-Spigot-a93cbb1-7a6c3c9]
at org.bukkit.craftbukkit.v1_16_R3.CraftServer.enablePlugins(CraftServer.java:408) ~[spigot-1.16.4.jar:git-Spigot-a93cbb1-7a6c3c9]
at net.minecraft.server.v1_16_R3.MinecraftServer.loadWorld(MinecraftServer.java:435) ~[spigot-1.16.4.jar:git-Spigot-a93cbb1-7a6c3c9]
at net.minecraft.server.v1_16_R3.DedicatedServer.init(DedicatedServer.java:218) ~[spigot-1.16.4.jar:git-Spigot-a93cbb1-7a6c3c9]
at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:809) ~[spigot-1.16.4.jar:git-Spigot-a93cbb1-7a6c3c9]
at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$0(MinecraftServer.java:164) ~[spigot-1.16.4.jar:git-Spigot-a93cbb1-7a6c3c9]
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_302]]]]

I have crashpayment install.

If someone can help me! Should be great
Thanks

When opening the PlayerList GUI, where you can select players and set their claim/sub claim permissions, the buttons named:

• page-display
• next-button
• previous-button
• back-button

even if configured, will still be the default, they won't change.

This behavior happens only in the PlayerList GUI, in other GUI those buttons are fine.

All claim settings seem to effect entities as well. My players are reporting that sheep cannot eat grass and animals cannot use pressure plates while in a claim.

I believe the only entities that should be effected by default are creepers, enderman, and such that do actual damage to the claims.

I suggest that you add a /claimban command, kind of like /claimeject just it removes the user from your claim and disallows them from entering your claim again.

Also add a /claimunban command to unban users if desired.

Hi, it's possible to add a claim tool? Left or right click for directly claim and other click for info in this chunk

When in the claimsettings menu, although you cannot click and move items in your inventory, you can hover over an empty slot in the claimsettings inventory and press a number on your keyboard that corresponds to a hotbar slot therefore moving the item(s) into the menu inventory. Doing this will mean you permanently lose the item

Ability to trade with villagers but not kill them

When someone try to unsubclaim while not standing in a claim, it throws a nullpointer exception in the console.

[23:51:08 ERROR]: [CrashClaim] [ACF] Exception in command: unclaimsubclaim
[23:51:08 ERROR]: [CrashClaim] [ACF] java.lang.NullPointerException: Cannot invoke "net.crashcraft.crashclaim.claimobjects.Claim.getSubClaim(int, int)" because the return value of "net.crashcraft.crashclaim.data.ClaimDataManager.getClaim(int, int, java.util.UUID)" is null
[23:51:08 ERROR]: [CrashClaim] [ACF] at CrashClaim.jar//net.crashcraft.crashclaim.commands.MenuCommand.unSubClaim(MenuCommand.java:57)
[23:51:08 ERROR]: [CrashClaim] [ACF] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[23:51:08 ERROR]: [CrashClaim] [ACF] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
[23:51:08 ERROR]: [CrashClaim] [ACF] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[23:51:08 ERROR]: [CrashClaim] [ACF] at java.base/java.lang.reflect.Method.invoke(Method.java:568)
[23:51:08 ERROR]: [CrashClaim] [ACF] at CrashClaim.jar//net.crashcraft.crashclaim.acf.RegisteredCommand.invoke(RegisteredCommand.java:152)
[23:51:08 ERROR]: [CrashClaim] [ACF] at CrashClaim.jar//net.crashcraft.crashclaim.acf.BaseCommand.executeCommand(BaseCommand.java:578)
[23:51:08 ERROR]: [CrashClaim] [ACF] at CrashClaim.jar//net.crashcraft.crashclaim.acf.BaseCommand.execute(BaseCommand.java:513)
[23:51:08 ERROR]: [CrashClaim] [ACF] at CrashClaim.jar//net.crashcraft.crashclaim.acf.RootCommand.execute(RootCommand.java:99)
[23:51:08 ERROR]: [CrashClaim] [ACF] at CrashClaim.jar//net.crashcraft.crashclaim.acf.BukkitRootCommand.execute(BukkitRootCommand.java:84)
[23:51:08 ERROR]: [CrashClaim] [ACF] at org.bukkit.command.SimpleCommandMap.dispatch(SimpleCommandMap.java:155)
[23:51:08 ERROR]: [CrashClaim] [ACF] at org.bukkit.craftbukkit.v1_20_R1.CraftServer.dispatchCommand(CraftServer.java:1007)
[23:51:08 ERROR]: [CrashClaim] [ACF] at org.bukkit.craftbukkit.v1_20_R1.command.BukkitCommandWrapper.run(BukkitCommandWrapper.java:64)
[23:51:08 ERROR]: [CrashClaim] [ACF] at com.mojang.brigadier.CommandDispatcher.execute(CommandDispatcher.java:265)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.commands.CommandDispatcher.performCommand(CommandDispatcher.java:324)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.commands.CommandDispatcher.a(CommandDispatcher.java:308)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.server.network.PlayerConnection.a(PlayerConnection.java:2343)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.server.network.PlayerConnection.lambda$handleChatCommand$20(PlayerConnection.java:2303)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.util.thread.IAsyncTaskHandler.b(IAsyncTaskHandler.java:59)
[23:51:08 ERROR]: [CrashClaim] [ACF] at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.server.TickTask.run(TickTask.java:18)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.util.thread.IAsyncTaskHandler.d(IAsyncTaskHandler.java:153)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.util.thread.IAsyncTaskHandlerReentrant.d(IAsyncTaskHandlerReentrant.java:24)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.server.MinecraftServer.b(MinecraftServer.java:1341)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:197)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.util.thread.IAsyncTaskHandler.x(IAsyncTaskHandler.java:126)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.server.MinecraftServer.bg(MinecraftServer.java:1318)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.server.MinecraftServer.x(MinecraftServer.java:1311)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.util.thread.IAsyncTaskHandler.c(IAsyncTaskHandler.java:136)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.server.MinecraftServer.p_(MinecraftServer.java:1289)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.server.MinecraftServer.w(MinecraftServer.java:1177)
[23:51:08 ERROR]: [CrashClaim] [ACF] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:320)
[23:51:08 ERROR]: [CrashClaim] [ACF] at java.base/java.lang.Thread.run(Thread.java:833)

To replicate, simply join the server, go in a random place where there are no claims and run the command.

Environment:
This server is running Pufferfish version git-Pufferfish-22 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 2bc9d45 on HEAD)
CrashClaim 1.0.39

This seems to be a rather major issue/bug within the plugin, my players found it out today and I will do my best to explain it after my testing.

Issue: Player A owns the Main Claim and grants Player B admin permissions within the Main Claim. Player B can now create Sub-Claims within Player A's Main Claim. The Sub-Claim instantly gives ownership to Player A as they own the Main Claim, but Player A cannot access/see the Sub-Claim in the GUI. Player B can access/see the Sub-Claim without issues and modify the permissions, but cannot grant Player A permissions within the Sub-Claim as Player A doesn't show up in the "Per-Player Settings" due to technically owning the Sub-Claim. Player A can still break/build and such within the Sub-Claim, but they cannot edit the global/player settings within it.

In this example, Player A would be the Owner of the main claim. Player B would be the Admin of the main claim.

Screenshot of the Main Claim information from Player A (Owner) https://imgur.com/a/JnzuAaw
Screenshot of the Main Claim information from Player B (Admin). https://imgur.com/a/OXQtf1k
Screenshot of Player B having Admin within the Main Claim. https://imgur.com/a/OCPJy5r
Screenshot of the Sub-Claim showing up in the GUI for Player B (Admin). https://imgur.com/a/O69GNu6
Screenshot of the Sub-Claim not showing up in the GUI for Player A (Owner). https://imgur.com/a/CIwPJ6O
Screenshot of Player B (Admin) not being able to give Player A (Owner) permissions to view/edit permissions of the Sub-Claim. https://imgur.com/a/yo07soG

If you need more information or screenshots of things, just reply and I will do my best to give you more as needed.

Hello, we have just started using crash claims on the server, it was working fine on 1.19 but 1.19.1 doesn't work properly due to the following error:

21.08 20:58:50 [Server] ERROR Could not pass event InventoryClickEvent to CrashClaim v1.0.33
21.08 20:58:50 [Server] INFO java.lang.NoSuchMethodError: 'net.minecraft.world.entity.player.PlayerInventory net.minecraft.server.level.EntityPlayer.fB()'
21.08 20:58:50 [Server] INFO at net.wesjd.anvilgui.version.Wrapper1_19_R1$AnvilContainer.<init>(Wrapper1_19_R1.java:88) ~[CrashClaim.jar:?]
21.08 20:58:50 [Server] INFO at net.wesjd.anvilgui.version.Wrapper1_19_R1.newContainerAnvil(Wrapper1_19_R1.java:82) ~[CrashClaim.jar:?]
21.08 20:58:50 [Server] INFO at net.wesjd.anvilgui.AnvilGUI.openInventory(AnvilGUI.java:177) ~[CrashClaim.jar:?]
21.08 20:58:50 [Server] INFO at net.wesjd.anvilgui.AnvilGUI.<init>(AnvilGUI.java:165) ~[CrashClaim.jar:?]
21.08 20:58:50 [Server] INFO at net.wesjd.anvilgui.AnvilGUI.<init>(AnvilGUI.java:30) ~[CrashClaim.jar:?]
21.08 20:58:50 [Server] INFO at net.wesjd.anvilgui.AnvilGUI$Builder.open(AnvilGUI.java:491) ~[CrashClaim.jar:?]
21.08 20:58:50 [Server] INFO at net.crashcraft.crashclaim.menus.ClaimMenu.onClick(ClaimMenu.java:168) ~[CrashClaim.jar:?]
21.08 20:58:50 [Server] INFO at net.crashcraft.crashclaim.crashutils.menusystem.CrashMenuController.onInventoryClickEvent(CrashMenuController.java:44) ~[CrashClaim.jar:?]
21.08 20:58:50 [Server] INFO at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor593.execute(Unknown Source) ~[?:?]
21.08 20:58:50 [Server] INFO at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:75) ~[purpur-api-1.19.1-R0.1-SNAPSHOT.jar:?]
21.08 20:58:50 [Server] INFO at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[purpur-api-1.19.1-R0.1-SNAPSHOT.jar:git-Purpur-1746]
21.08 20:58:50 [Server] INFO at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[purpur-api-1.19.1-R0.1-SNAPSHOT.jar:?]
21.08 20:58:50 [Server] INFO at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:678) ~[purpur-api-1.19.1-R0.1-SNAPSHOT.jar:?]
21.08 20:58:50 [Server] INFO at net.minecraft.server.network.ServerGamePacketListenerImpl.handleContainerClick(ServerGamePacketListenerImpl.java:3369) ~[?:?]
21.08 20:58:50 [Server] INFO at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:58) ~[?:?]
21.08 20:58:50 [Server] INFO at net.minecraft.network.protocol.game.ServerboundContainerClickPacket.handle(ServerboundContainerClickPacket.java:23) ~[?:?]
21.08 20:58:50 [Server] INFO at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:51) ~[?:?]
21.08 20:58:50 [Server] INFO at net.minecraft.server.TickTask.run(TickTask.java:18) ~[purpur-1.19.1.jar:git-Purpur-1746]
21.08 20:58:50 [Server] INFO at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?]
21.08 20:58:50 [Server] INFO at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?]
21.08 20:58:50 [Server] INFO at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1386) ~[purpur-1.19.1.jar:git-Purpur-1746]
21.08 20:58:50 [Server] INFO at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:185) ~[purpur-1.19.1.jar:git-Purpur-1746]
21.08 20:58:50 [Server] INFO at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?]
21.08 20:58:50 [Server] INFO at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1363) ~[purpur-1.19.1.jar:git-Purpur-1746]
21.08 20:58:50 [Server] INFO at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1356) ~[purpur-1.19.1.jar:git-Purpur-1746]
21.08 20:58:50 [Server] INFO at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:136) ~[?:?]
21.08 20:58:50 [Server] INFO at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1334) ~[purpur-1.19.1.jar:git-Purpur-1746]
21.08 20:58:50 [Server] INFO at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1222) ~[purpur-1.19.1.jar:git-Purpur-1746]
21.08 20:58:50 [Server] INFO at net.minecraft.server.MinecraftServer.lambda$spin$1(MinecraftServer.java:310) ~[purpur-1.19.1.jar:git-Purpur-1746]

The server version is

21.08 21:03:47 [Server] INFO Current: git-Purpur-1746 (MC: 1.19.1)*
21.08 21:03:47 [Server] INFO Previous: git-Purpur-1735 (MC: 1.19)
21.08 21:03:47 [Server] INFO * You are 5 version(s) behind

hopefully this helps!

On my server, I use the plugin ChestShop [https://www.spigotmc.org/resources/chestshop.51856/]. Since switching to CrashClaims recently, players cannot interact with ChestShop signs in claims unless "interaction" is enabled.

The issue with this is Interaction gives players access to more than just these ChestShop signs which is not ideal.