weprovide / magento2-module-nginx-redirect Goto Github PK

When a success and/or error message is added to \Magento\Framework\Message\ManagerInterface it isn't shown in the frontend after a redirect.

An example is editing a redirect, deleting that redirect in another tab and saving the redirect in the tab with the edit page open. An error is added to \Magento\Framework\Message\ManagerInterface that the redirect doesn't exist anymore but this error isn't shown on the redirect listing page.

Also make sure output dir exists using Magento filesystem

Prevent redirect loops.

Scenario 1

1. redirect /foo to /bar
2. redirect /bar to /foo

Scenario 2

1. redirect /foo to /bar
2. redirect /bar to /taylor-swift
3. redirect /taylor-swift to /foo

Aside of only redirects (301, 302) also support rewrites, see https://support.hypernode.com/knowledgebase/rewriting-and-redirecting-urls-in-nginx/

Service contracts allow depending modules to depend on the interface of the redirect model and it's respective repository instead of its concrete implementation.

Service contract design patterns | Magento 2 Developer Documentation

Interfaces can also be used in classes owned by the module itself to keep a clean and more readable codebase by using the repository interface instead of a factory or collection for example to load one or more redirect models directly.

Suggested interfaces
WeProvide\NginxRedirect\Api\Data\RedirectInterface
WeProvide\NginxRedirect\Api\RedirectRepositoryInterface

• Output validation, see https://wincent.com/wiki/Checking_nginx_config_file_syntax
• Input validation or some kind of rules engine

• Only write output when something has changed (compare files and swap / store modified timestamp)
• Reload nginx
• Prevent writes when writing :)

Must support Magento CE & EE and make sure it's safe!