weilu / cb-wallet Goto Github PK

As discussed in bitcoinjs/bitcoinjs-lib#260 (comment), I feel like the 'all-in-one' design of the Wallet right now is too overwhelming, and leads to bad separation of concerns.

In essence the design needs to cater for three things:

• Provide a simplified key management API,
  • With the ability to generate/iterate addresses using BIP32,
  • and the ability to sign transactions with addresses
• Provide unspent Transaction outputs aggregation,
  • With functionality to provide candidates for a particular output value, and
  • Capability to check balance based on blockHeight/confirmations
• Unspent Transaction output utility functions, such as
  • Create Transaction from inputs, outputs and optional change address, fee

As an example of what this API might look like, here is an example for spending:

var satoshis = 1e5
var inputs = unspents.candidates(satoshis)
var addresses = inputs.filter(function(inputs) { return u.address })

var tx = utils.createTransaction(inputs, outputs, { change: '18eRuS...' , fee: 0 })

wallet.sign(tx).with(addresses)
blockchain.propagate(tx, function(err) {
   ...
})

Then perhaps even a check to see if your address is used might just be:

if (unspents.contains(address)) {
  wallet.next()
}

Thoughts?

Using BIP32-utils discovery might be:

bip32utils.discovery(wallet.getExternalAccount(), 20, function(addresses, callback) {
  blockchain.addresses.summary(addresses, function(err, results) {
    if (err) return callback(err)

    var areSpent = results.map(function(result) {
      return result.totalReceived > 0
    })

    callback(undefined, areSpent)
  })
}, function(err, k) {
  if (err) return done(err)

  console.warn('Discovered ' + k + ' addresses')
  wallet.generate(0, k)

  done()
})

See: #2 (comment)