Hey, I was porting code like this <a href="https://github.com/google

The new version doesn't fix it, but I have a minimal repro: <div class="highlight

I've just tried: <div class="highlight highlight-source-js notranslate position-re

P.S. the window , in linkedom , has to be retrieved via <code class="n

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Attributes missing about linkedom HOT 7 CLOSED

webreflection commented on June 29, 2024 1

Attributes missing

from linkedom.

Comments (7)

cramforce commented on June 29, 2024 1

The new version doesn't fix it, but I have a minimal repro:

const { parseHTML } = require("linkedom");

console.log(
  `type="test" is retained`,
  parseHTML(`<!doctype html><script type="test"></script>`).document.toString()
);

console.log(
  `type="test" is dropped`,
  parseHTML(`<!doctype html><script type="test">X</script>`).document.toString()
);

Output:

type="test" is retained <!DOCTYPE html><html><script type="test"></script></html>
type="test" is dropped <!DOCTYPE html><html><script>X</script></html>

from linkedom.

WebReflection commented on June 29, 2024

I've just tried:

const {document} = parseHTML('');
document.head.innerHTML = `<script csp-hash="any"></script>`;
console.log(document.querySelector("script[csp-hash]").toString());

And the outcome is:

<script csp-hash="any"></script>

While document.toString() produces:

<!DOCTYPE html><html><head><script csp-hash="any"></script></head></html>

Is it something inside the script that is not available? <script>, together with <style> or <textarea> and <title> have a special behavior for content, as these don't accept Element nodes inside.

from linkedom.

WebReflection commented on June 29, 2024

P.S. the window, in linkedom, has to be retrieved via document.defaultView but it doesn't have a document attached ... that is something I can fix though.

edit this change is in.

from linkedom.

WebReflection commented on June 29, 2024

I've made a few changes that maybe help you sorting out what's going on:
https://github.com/WebReflection/linkedom#simulating-json-bootstrap

from linkedom.

WebReflection commented on June 29, 2024

@cramforce there are a lot of tiny fixes in the latest version, please have a look at both how to simulate JSDOM and with latest, to see if your problem is gone.

I don't have much to reproduce or test, so if I won't hear from you in a couple of days, I'll close this 👋

from linkedom.

WebReflection commented on June 29, 2024

Thanks for the reproducible example!

FWIW, it's a specific <script> special case (change name to see it working), meaning it likely affects <style> and <title> too ... these are all special cases, and I'll try to fix this ASAP as these are also most important nodes that should work 😅

thank for your patience, I'll come back hopefully sooner than later.

from linkedom.

WebReflection commented on June 29, 2024

@cramforce this issue has been fixed, I hope you won't have any other, but if that's the case, please open a new issue and I'll follow up. Thanks for the example, it helped a lot (and it should've been in my coverage in the first place).

Now all cases are tested, and it's green 👍

from linkedom.

Recommend Projects

Attributes missing about linkedom HOT 7 CLOSED

Comments (7)

Output:

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent