&quot converted to " on xml about linkedom

[omril1]

@WebReflection If I understand this correctly, the escape function in toString doesn't escape quotes, so the replace should be called for XML documents as well.

So this:

linkedom/cjs/interface/attr.js

Lines 44 to 51 in 85d9f92

	toString() {
	const {name, [VALUE]: value} = this;
	if (emptyAttributes.has(name) && !value) {
	return ignoreCase(this) ? name : `${name}=""`;
	}
	const escapedValue = ignoreCase(this) ? value.replace(QUOTE, '"') : escape(value);
	return `${name}="${escapedValue}"`;
	}

Should change to:

  toString() {
    const {name, [VALUE]: value} = this;
    if (emptyAttributes.has(name) && !value) {
      return ignoreCase(this) ? name : `${name}=""`;
    }
-    const escapedValue = ignoreCase(this) ? value.replace(QUOTE, '"') : escape(value); 
+    const escapedValue = (ignoreCase(this) ? value : escape(value)).replace(QUOTE, '"');
    return `${name}="${escapedValue}"`;
  }

[WebReflection]

I don't know ... that change is recent and it was to avoid escaping other chars such as & but not single quote or others ... the double quote escape is actually due common double quotes used around attributes but I feel like there's no right answer here ... or better, I would like to read an exhaustive example and and a test with expectations and never change this again, thanks!

[nyanrus]

it is double quote issue.