Coder Social home page Coder Social logo

Comments (7)

WebReflection avatar WebReflection commented on August 18, 2024

What a regression, will fix ASAP! Thanks

from document-register-element.

WebReflection avatar WebReflection commented on August 18, 2024

Also please feel free to use 0.8 for the time being as it's not inferior in terms of features

from document-register-element.

WebReflection avatar WebReflection commented on August 18, 2024

OK, I've done a bit of investigation. IE9 and IE10 works just fine, the problem here is that these two should use HTMLUnknownElement as default prototype, instead of HTMLElement which is inconsistent with other browsers behavior, including IE11.

Long story short, I need to feature detect this somehow and try to fix it, if possible, but that would make them inconsistent anyway so I'll think about it.

Meanwhile I can assure you that nothing is actually broken and the reason contractor was red is that there was no constructor test before in 0.8.0

Feel free to use 0.1.x in those browsers too as you can see now the test is green.

from document-register-element.

chrisbateman avatar chrisbateman commented on August 18, 2024

My apologies for not researching this more thoroughly. I have a better idea of what's happening now.

Beggining in 0.1.0 - only in IE 9 and 10 - you cannot include your document.registerElement calls in the <head> (unless you wrap them in a window.onload, or similar). This was possible in 0.0.8.

You can duplicate the issue using the "Usage Example" in the readme.

It's not too hard to work around, but it doesn't match native behavior, so it might be worth documenting...

from document-register-element.

WebReflection avatar WebReflection commented on August 18, 2024

would you be so kind to double verify that version 0.1.2 is working properly for you ? Thanks

from document-register-element.

chrisbateman avatar chrisbateman commented on August 18, 2024

It is working. That was fast! Thank you very much - this is a great polyfill!

from document-register-element.

WebReflection avatar WebReflection commented on August 18, 2024

I might find a better/more performant way to trigger that check at runtime via DOMContentLoaded instead of readystatechange that might fire multiple times but it was more important to fix this so I hope you won't mind closing this ticket if you think this problem is solved.

I will solve the other constructor problem a part thought, but in another ticket and when I'll be back from this little vacation :-)

Have a great weekend.

from document-register-element.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.