Coder Social home page Coder Social logo

Comments (6)

WebReflection avatar WebReflection commented on June 22, 2024 2

So, v1.13.0 is out, and I've also added a how to migrate to V1 with hopefully all the details in (already spotted few typos though, on it already)

from document-register-element.

WebReflection avatar WebReflection commented on June 22, 2024 1

I still need to support IE11

IE doesn't have customElements so that script tag on top of any of your page would work for IE11 (and many others).

If I remove document-register-element, it works in Firefox too.

That means you shouldn't use DRE in the first place.

I'll try to have a look what is wrong or how I can improve but it seems like you are giving DRE to browsers that shouldn't need it.

Anyway, worth investigating.

from document-register-element.

WebReflection avatar WebReflection commented on June 22, 2024

Are there any plans to remove support for Custom Elements V0 from this polyfill, considering that browsers are already dropping it?

No, but you shouldn't care. V0 is battle tested and used to bring built ins to V1 capable browsers.

Firefox has also been tested extensively, so unless you tell me which version you are using, it's hard for me to do anything here.

The outerHTML trick you mentioned is used in built-in-element which patches only built-in extends for non capable browsers: https://github.com/WebReflection/built-in-element

If you want to use V1 built-in elements, I strongly suggest you use that polyfill instead.

The way you'd go for it is described in the Medium post, summarized as:

<script>
if (!this.customElements)
  document.write('<script src="//unpkg.com/document-register-element"><\x2fscript>');
</script>

You can test the live page there: https://webreflection.github.io/built-in-element/test/es5/

from document-register-element.

gkubisa avatar gkubisa commented on June 22, 2024

Sorry, I should have mentioned the version... it's Firefox 63.0 (64-bit) on Ubuntu 16.04.

I still need to support IE11, so I believe https://github.com/WebReflection/built-in-element would not be enough and I have to use https://github.com/WebReflection/document-register-element.

from document-register-element.

gkubisa avatar gkubisa commented on June 22, 2024

I've just created this jsfiddle to demonstrate the problem: https://jsfiddle.net/0dm72zv6/4/. It works fine in Chrome but fails in Firefox 63. If I remove document-register-element, it works in Firefox too.

from document-register-element.

gkubisa avatar gkubisa commented on June 22, 2024

Ah, that makes sense. Thanks!

Still, I believe that loading document-register-element should be safe in any browser, even if it is not needed.

from document-register-element.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.