Patched createdElement breaks instanceof. about document-register-element

[WebReflection]

you got me there, I've never thought somebody would've used node instanceof HTMLElement to distinguish between nodes, instead of node.nodeName which for non custom elements makes much more sense, IMO.

However, no excuses, my poly breaks these expectations and it shouldn't.
I'm thinking about a solution, because patching document.createElement is not enough: any native element could be grabbed at any time ... this is a tough one.

[WebReflection]

actually, would you mind trying 1.0.2 and tell me if it fixes the issue?

[WebReflection]

actually I have a test in place that shows it's fixed now. Thanks

[Florian-R]

Wow, that was quick, you were faster to fix it than me to locate the bug 👍. I can confirm the fix is OK with 1.0.4.

Me just being curious, any reason you've used Object.defineProperty in the first time?

Thanks a lot.

[WebReflection]

Because inheriting gives me full privileges to my prototype while natives are extremely differently handled by various vendors. WebKit has it frozen, others have some property non configurable but writable, etc. Indeed, with latest I'm working on right now, Safari can't possible have the constructor overwrite but at least instanceof works as expected.

[Florian-R]

I see. Thanks for the heads up.