web-push-libs / web-push Goto Github PK

As suggested here: SeleniumHQ/selenium#1100

They're hard to detect otherwise.

Very low priority.

The sendNotification tests should be extended to test the GCM case as well.

Depends on #51.

This should be tested both in Firefox and in Chrome.

Make sure the implementation works with empty messages.

There's a distinction between notifications without a message and notifications with an empty message:
mozilla-services/autopush#132 (comment)
w3c/push-api#161

https://tools.ietf.org/html/draft-ietf-webpush-protocol-00#section-7.3

Currently, we don't check if the files defined in importScripts actually exist and we directly add the code to import them in the service worker.
We should check if they exist and throw an exception or print a warning message if they don't.

We could add this feature either to oghliner or sw-precache, @mykmelez what do you think? It really depends on whether we plan to remove the dependency on sw-precache in the future.

Currently the version is hardcoded in the selenium-init script, so once a new Firefox Nightly version will be released, the script will be broken.

I'd like to build a test that makes it possible to exercise the entire stack.

I'm not sure how to build such a test, maybe with SlimerJS.

The GCM API key is a secure environment variable, so it can't be used in pull requests. Because of this, Chrome tests will always fail in pull requests.

Using the info the push service returns (webpush-wg/webpush-protocol#60).

Register for notifications, close browser, send notification, open browser, check if notification has arrived.

Currently tests are working on Linux.
I failed to make it work on OSX without changing selenium-init.js

They're very timing-dependent at the moment (the notification could arrive before the page has been loaded), we need a way to make them reliable.

We could download it automatically and then do:

var firefox = require('selenium-webdriver/firefox');
var binary = new firefox.Binary('/path/to/firefox-bin');
var options = new firefox.Options().setBinary(binary);
var driver = new firefox.Driver(options);

Instead of:

var driver = new webdriver.Builder()
    .forBrowser('firefox')
    .build();

https://github.com/chrisdavidmills/push-api-demo

There are strings enclosed in double quotes and other strings in single quotes. I prefer single quotes.

On Linux, I'm creating a policy file. On OS X creating a policy file is a little more complicated, I don't know if it's feasible on Travis.

For now, only https://github.com/marco-c/tictactoe/

I guess this could be useful for apps targeting older versions of Firefox OS.

We can either create a .npmignore file (such as https://github.com/socketio/socket.io/blob/master/.npmignore) or explicitely list the files we want to export (e.g. https://github.com/senchalabs/connect/blob/master/package.json or https://github.com/strongloop/express/blob/master/package.json).

We could install the Mozilla push server and test that our library is able to communicate with it.

https://github.com/mozilla-services/autopush