Comments (1)
Just came across this while searching for something and was confused why it would be closed with no reply!! Eventually remembered that we moved to email. I'm going to post my reply for future reference / in case others find these questions when searching the issues..
Hi there,
Here are my answers to the best of my understanding:
- Yes we could. It is a bit annoying though to implement the original article because the geometry LODs are manually stitched together, and things like T-junctions are handled manually (complex, tedious, inefficient). The original work also relies on per-frame upload from CPU to GPU (tedious, complex, potentially inefficient if not implemented carefully). Finally, because our vertex layouts match 1:1 at the transitions between LODs, we can use a simple interpolation of the shape data. Without this, it is painful to get a perfect transition between LODs. It's hard to describe concisely why this is the case, but the problems arise when a vert in a hi-res LOD sits above a diagonal edge in a lo-res LOD - here the vert height needs to be the average height of the two verts of the edge, not the average of the 4 surrounding verts. This is subtlely different and will result in z-fighting, and this problem took us a while to understand. McGuire performs the interpolation manually to ensure the verts that lie over an edge in the next LOD get the precise correct height:
"To eliminate discontinuities in elevation between grid resolutions, I use an explicit form of "trilinear" (MIP-map) interpolation. Vertices interpolate vertically towards the next lower-detail MIP level so that they exactly match the next resolution at the edge of a grid patch."
-
Our patches have strictly no overlap - this is convenient for the reasons i list on the slides. We choose to compose the geometry from patches as they can be frustum culled which is efficient, although McGuire reported minimal speedup from patches. One direction for future work would be to instance the patches to reduce draw calls. I've left it as is for simplicity/laziness :).
-
Yes good question, it took us a while to figure out there is overlap in mcguires work. He doesn't mention it! I'm certain it is there - it is required because the LOD geometry snaps to different resolutions and gaps would open up without it (to see roughly what this looks like, run our crest project in unity and disable "Smooth LOD" using the onscreen debug overlay, and look for the gaps). After puzzling for some time we realised mcguire uses overlaps to hide them. Look very closely at that the top image in this figure, at the boundaries between LODs: http://4.bp.blogspot.com/-wZrpKfO3YMU/U0lX7WrRxEI/AAAAAAAABfA/bnXyIIXXRZY/s1600/2014-03-29_004_terrain_r997_g3d_r4283.jpg . At the lod transition you can see zfighting in the higher res geom - sometimes verts are visible, sometimes not. This is because the hi- and lo-res geometry overlap and mcguire is rendering the visualisation with z-testing enabled, so they z-fight. This z-fighting is ok for terrain (i guess?) but disturbing for specular shading on water - this reason and the other reasons listed in our slides motivated us to eliminate overlaps between patches in our solution.
Hopefully the above makes sense or at least serves as good pointers for further thinking!
from crest.
Related Issues (20)
- HDRP underwater volumetric lights not working properly HOT 2
- Local / movable spectrums or crest shapes HOT 3
- Foam / wake vibration when approaching whirlpools HOT 20
- Pressing the Windows Key in the editor disables underwater rendering HOT 3
- Wake / foam artifacts when moving the camera quickly HOT 11
- Delayed LOD / tile enabling when using large clipping areas HOT 5
- Depth Cache not populated - Exported Image is Black HOT 8
- Water interaction is not visible when moving camera away from the sea level HOT 1
- Underwater broken with XR multi-pass rendering HOT 1
- No caustics, no shadow data and/or constant shadowing on iOS
- Error of Does not exist some Classes. HOT 1
- Sporadic gaps / precision errors in tiles. HOT 31
- SphereWaterInteraction and RegisterDynamicWavesInput do not work correctly inside a flow area HOT 11
- Activating flow in the material when oceanrenderer is running does only work in editor HOT 2
- FindObjectsSortMode HOT 3
- Enable Shader API does not function without changing underwater appearance HOT 20
- Enable Shader API causes artifacts HOT 4
- Planar Reflections issue with non-standard shaders using transparency HOT 13
- Premature tile culling during extreme camera maneuvers above the ocean HOT 1
- Portal feature broken with Unity Recorder 360 View
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crest.