waterviewsrl / irondomo

ZeroMQ Majordomo Pattern with CURVE authentication

IronDomo

ZeroMQ Majordomo Pattern with CURVE authentication, allowing encripted and clear communication between clients and workers.

Extends ZMQ Majordomo (https://rfc.zeromq.org/spec:7/MDP) pattern with CURVE authentication and encription
It provides a Broker with two endpoints for client connection, providing both a clear and a trusted communication channels.

APIs

APIs and examples are provided for python3 and C/C++.

Python

The package can be installed from source or directly from pip

pip install irondomo

Examples provide documentation of the various APIs and necessary configuration

C/C++

APIs are provided for C and C++ as header only distribution in order to simplify target build. Examples provide documentation of the various APIs and necessary configuration Please find information on how to build and run these examples here: https://github.com/desmoteo/IronDomo/blob/master/C/examples/README.md

irondomo's Issues

C: IronDomo broker leaks memory

in s_broker_worker_msg()
zframe_t * command is not properly released.
in idbrokerapi.h:282 free() is called on the zframe pointer. This should be zframe_destroy().

broker implementation in C not purging expired workers

s_broker_purge() is assuming workers in the self->_waiting list are sorted by oldest first.

the original libmdp achieved that by pushing a worker element to the end of the list upon a heartbeat received.
that part is missing in your implementation.

As a result expired workers are never purged from the _waiting list.

To fix:
idbrokerapi.h:259ff should read:

} else if (zframe_streq(command, IDPW_HEARTBEAT)) {
       if (worker_ready) {
           if (zlist_size(self->_waiting) > 1) {
               // Move worker to the end of the waiting queue,
               // so s_broker_purge will only check old worker(s)
               zlist_remove(self->_waiting, worker);
               zlist_append(self->_waiting, worker);
           }
           worker->_expiry = zclock_time() + HEARTBEAT_EXPIRY;

cheers,

Joerg