Comments (2)
lws-team
commented on July 21, 2024
I'm willing to believe something broke with the update stuff, but confusing as it is, LWS_IS_FACTORY_APPLICATION (== 1) is completely distinct from CONFIG_LWS_IS_FACTORY_APPLICATION (==y).
The latter is set in sdkconfig which for me is
CONFIG_LWS_IS_FACTORY_APPLICATION=y
We pass LWS_IS_FACTORY_APPLICATION into the build as it is, without any CONFIG_ ... I think nothing uses it atm
-DLWS_IS_FACTORY_APPLICATION=$(LWS_IS_FACTORY_APPLICATION)
from lws-esp32-factory.
jas39
commented on July 21, 2024
This is due to an error in components/libwebsockets/plugins/protocol_esp32_lws_scan.c where the following #ifdef on row 218 should be changed from
#if CONFIG_LWS_IS_FACTORY_APPLICATION == 'y' && defined(CONFIG_LWS_OTA_SERVER_BASE_URL) && defined(CONFIG_LWS_OTA_SERVER_FQDN)
to
#if defined(CONFIG_LWS_IS_FACTORY_APPLICATION) && defined(CONFIG_LWS_OTA_SERVER_BASE_URL) && defined(CONFIG_LWS_OTA_SERVER_FQDN)
(it is actually defined as == 1 in the generated sdkconfig.h but the above is the way it is used in other files)
from lws-esp32-factory.
Related Issues (20)
- lws-esp32-factory/components/bootloader/Makefile.projbuild:37: *** multiple target patterns. Stop. HOT 3
- oto_choose_part will accept partition outside range HOT 2
- INFO: ota update of factory partition fails HOT 8
- lws-esp32-factory is always listed as dirty HOT 4
- Does it link on ESP32 HOT 2
- Connection terminates after approximetly 10 minutes HOT 3
- Minor: Missing "hard" for Git command in Readme HOT 1
- Lets Encrypt stops at first step
- tcp_connect: can only connect from state CLOSED
- Partition table too small for newer esp-idf HOT 4
- how to force enter app after first reboot HOT 7
- Updated alignment with esp-idf/mbedtls needed to build with latest esp-idf HOT 16
- websocket client example
- Error during make flash monitor HOT 2
- mbedtls_handshake: ssl ret -6900 state 8
- arduino-esp32 support ?
- multiple definition of api functions when using openssl api functions HOT 1
- build fail for lws-esp32-factory HOT 12
- Can this be used on esp8266 HOT 1
- Please give me an esp8266 program about LWS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lws-esp32-factory.