Comments (4)
Do you have any idea about how to square this with wanting to provide and maintain a reference sdkconfig?
Every time I update lws-esp-factory against esp-idf, there are new sdkconfig options... most of these are irrelevant, but some of these are critical design decisions about integration with lws at all (eg, lws provides dynamic "stretchy" tls buffers by patching mbedtls, which requires the related hack option in sdkconfig to be 16384). Another example is the hacks in lwip around "offset for socket fds".
If users don't align the sdkconfig with the necessary options for lws to do what it's doing, it won't work.
from lws-esp32-factory.
This request is not asking for file 'sdkconfig' to be added to the repository. This request is to add a line containing the file name to the existing '.gitignore' file.
From a user perspective, this change will be virtually invisible. He will still have to run 'make menuconfig' before he compiles. However git will no longer call the repository dirty when the file 'sdkconfig' is present.
from lws-esp32-factory.
... ignoring a file is inconsistent with git tracjing the file, right? Sdkconfig is already in the project
https://github.com/warmcat/lws-esp32-factory/blob/master/sdkconfig
Adding stuff being tracked to gitignore has no effect...
https://help.github.com/articles/ignoring-files/
What you suggested means removing sdkconfig from the project.
Please re-read my original reply with this in mind.
from lws-esp32-factory.
I now understand the issue and see where I was mistaken. I agree that the way the code is now is correct. Please close this issue.
Thanks
Jim
from lws-esp32-factory.
Related Issues (20)
- lws-esp32-factory/components/bootloader/Makefile.projbuild:37: *** multiple target patterns. Stop. HOT 3
- oto_choose_part will accept partition outside range HOT 2
- INFO: ota update of factory partition fails HOT 8
- Does it link on ESP32 HOT 2
- Connection terminates after approximetly 10 minutes HOT 3
- Minor: Missing "hard" for Git command in Readme HOT 1
- Lets Encrypt stops at first step
- tcp_connect: can only connect from state CLOSED
- Partition table too small for newer esp-idf HOT 4
- how to force enter app after first reboot HOT 7
- Updated alignment with esp-idf/mbedtls needed to build with latest esp-idf HOT 16
- websocket client example
- Error during make flash monitor HOT 2
- mbedtls_handshake: ssl ret -6900 state 8
- arduino-esp32 support ?
- multiple definition of api functions when using openssl api functions HOT 1
- build fail for lws-esp32-factory HOT 12
- Can this be used on esp8266 HOT 1
- Please give me an esp8266 program about LWS HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lws-esp32-factory.