Comments (3)
Hello there Paul,
Because Signshop depends on quite a few other plugins which are not "Maven connected", it is very hard to move Signshop over to a Maven project.
I did try this at some point but I ended up with a dirty Maven config file. Which just had a load of "hardcoded" JAR references. This, according to the Maven documentation, is bad practise. So we decided to give up on Maven support.
However, I am not an expert when it comes to Maven. And if you have any suggestions as to how Signshop can be a Maven enabled plugin without losing all the links to the plugins. Then I'd be happy to hear them.
Either way, thank you for taking the time to write up an issue.
With kind regards,
Wargamer
from signshop.
Hi Wargamer,
Thanks for the reply and apologies for the slow response on my part.
I must confess I am not a Maven expert. However, I have been playing about with Maven for a few months with my own plugins. I also have ran into this problem. Personally, I have worked around it by creating my own Maven repository (http://repo.pjt.me) and adding jars for un-Mavenized projects into the "3rd Party" repository that comes setup by default with Sonatype Nexus.
I think it is worth exploring whether there is any problem with including other people's jars in such a Maven repository. I would suspect that most jars we'd link against would either be open source or at least licensed such as to allow linking with other plugins.
If we can determine that it's acceptable to do this, then I might suggest.
- Use a custom Maven repository for this. I am happy to offer mine.
- Use a public Maven repository for this. It might be better to see if there is a nice common Bukkit related Maven repo we could submit "3rd Party" plugins to.
For now for using your plugin, I have included SignShop.jar in my repository. Is this ok with you? If you are interested in pursuing any of the above, let me know and I am happy to help.
One last thought might be to do exactly as I am doing with you and see if other plugins developers are interested in becoming Mavenized. IMHO, it's a no-brainer for linkable / hookable / apied plugins, if at all possible. :)
Cheers,
Paul Thompson
aka captbunzo
from signshop.
Hello Paul,
First of all, I'd really like to thank you for shedding some light on the magic called Maven. I will consider hosting the 3rd party libs on a Maven repo (for as far as licensing allows me to).
I'm OK with Signshop being hosted on Maven, whether it's yours or any other. It's open source for a reason. As long as it's labeled like it should be, 3rd party.
Do let me know if you need any help with hooking into Signshop.
With kind regards,
Wargamer
from signshop.
Related Issues (20)
- [Suggestion] Expand the trade feature HOT 1
- Bug for 1.17.1 HOT 3
- Only the Admin Shop Owner can use Admin Shops. Why? HOT 1
- SignShop sometimes not working correctly (signs) HOT 9
- Sop sign is bugged (again) HOT 1
- Transactions failed to add money when selling too quick HOT 1
- Issue with iSell signs when sneaking HOT 2
- Skipping Ranks [Promote} HOT 14
- Permissions are not working at all (Tried Verbose too) HOT 6
- Moving from 1.17.1 to 1.18.1 and stuck on "Loading and validating shops, please wait..." HOT 9
- Add SignShop to pom.xml HOT 2
- pom.xml is not up to date HOT 4
- Get coordinates to linked container [Feature Request]
- SignShop throws IllegalStateException when enabling plugin HOT 5
- Question HOT 2
- Displaying colors on items when they are not colored, only named! HOT 2
- how to change [kit] plugin HOT 4
- Shift+right click via CMI breaks shop signs (even ones you dont have access too) HOT 1
- Dyeing already created shops HOT 1
- Can't Buy Problem (Changing Economy System) HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from signshop.