wardpearce / jellyfin-session-kicker

Session kicker after X amount of watch time for Jellyfin

My Sites

• wardpearce.com
• paaster.io
• materialio.us
• purplix.io
• capy.life

Contacts

• @wardpearce:matrix.org
• Matrix space
• mastodon.social/@wardpearce
• lemmy.nz/u/Ward
• [email protected]

jellyfin-session-kicker's Issues

Env varible default bool bug and feature to accrue time by device rather than user

os.getenv(A, B) looks for env variable A and returns B as a default if it doesn't exist. However variable B is always returned as a string, regardless of what the function was called with.

For DELETE_DEVICE_IF_NO_MEDIA_CONTROLS, B is set to the bool False, which gets converted to the string "False". This will always True for bool("False") since the string is not empty. This is a very annoying oversight from the python developers. A better check is:

DELETE_DEVICE_IF_NO_MEDIA_CONTROLS = os.getenv("DELETE_DEVICE_IF_NO_MEDIA_CONTROLS", "True").lower() == "true"

I've created a PR that includes this change. This PR also includes a new env variable that allows time to be accrued by DeviceId rather than UserId. So the same user with multiple devices is treated differently.

PR: #27

Auth issue.

I've tried several different ways to perform a GET request, making sure to include the Authorization header with the given basic token supplied at runtime, and I always received invalid auth. Here's an example of request and response:

root@63fa9d5d9c8b:/# curl jellyfin-session-kicker --header "Authorization: basic TJziSL1bx4X8fYLJZnlZHxyXOjvUgLdXXPGtbn7NyAgOsj4leJohXQ"
{"error": "Invalid basic auth credentials"}

I would greatly appreciate any help figuring this out! Or providing another means to whitelist would also work.

Thank you.