wangliang1989 / sacio_fortran Goto Github PK

Hi Liang,

I've created a SAC file by using your code. But when I use saclst to check some parameters, it raises an error:
sacio: Actual file size 19832 != expected file size: 39032 [npts: 4800]

I think the reason is that Fortran's character is not fully compatible with C's char *. In C, there should be an '\0' at the end of each char arrays to indicate its end.

To solve this problem, I think one way is to add a subroutine in the source file:

subroutine create_c_char(mychar)
  use iso_c_binding,only : c_null_char
  implicit none 
  character(len=*),intent(inout) :: mychar
  mychar = trim(mychar) // c_null_char
end subroutine

Before calling sacio_writesac/write_header, you could call this subroutine to convert all character arrays in sachead to C's char*. In addition, the length of each character array, like kstnm should have length 9 instead of 8.

Thanks!

1. 字母大小写

Fortran 是大小写不敏感语言，一些老一辈的程序员对保留字习惯使用大写

2. 锁进问题

Fortran 的习惯是子程序内、contains 语句后等都要锁进：

subroutine program
blabla
end subroutine

contains
blabla

以上习惯一般都是老一辈程序员的习惯，目前fortran官网依然保持，那么应该怎样更好呢？