wandersonwhcr / laminas-romans Goto Github PK

Currently I am trying to update namespaces from Zend\Romans to Laminas\Romans.

https://github.com/wandersonwhcr/laminas-romans/tree/feature/laminas 7234cda

In this branch I updated every requirement (include developing packages) and everything works like a charm.

But

https://github.com/wandersonwhcr/laminas-romans/tree/feature/laminas-with-errors 82b0dfa

This branch 82b0dfa is 1 commit ahead 7234cda and I only renamed namespaces. When I run composer test we find a problem with filter (service) manager because it can't find RomanToInt service.

php vendor/bin/phpunit --filter testRomanToIntFilter

This command shows the test with problem.

    public function testRomanToIntFilter()
    {
        $manager = $this->buildApplication()->getServiceManager()->get('FilterManager');

        $this->assertService($manager, Filter\RomanToInt::class, ['RomanToInt', 'romanToInt', 'romantoint']);
    }

Debugging our code, I realized that method Laminas\Romans\Module::getFilterConfig was automatically called on commit 7234cda and it wasn't on 82b0dfa, so our services are not initialized.

How can we fix that?

We must add this package to Packagist as Laminas.