wanderlanz / lender

std::iter feature complete(-ish) lending iterator for Rustlang

Hi there 👋

• 🔭 I’m currently working on a B.S. in Computer Science 🙂.
• 🌱 I’m currently learning cybersecurity & mobile development.
• 👯 I’m always looking to collaborate.
• 💬 Ask me anything.
• ⚡ Fun fact: I am a tubist 😎

🈷️ Languages

🏠 Operating Systems

lender's Issues

`last` is technically unsound?

last takes a self argument, but returns a lend from self... after dropping self... so a dangling pointer is possible... and somehow still passes MIRI tests? I can't tell if MIRI test is simply failing to catch this or I'm being dumb?

The fix is easy, use &mut self instead of self:

fn last(&mut self) -> ...

I am just opening this issue to make sure I'm not just being delusional at 2:30AM ...

I started working on a lending iterator crate, should I yank it and help you here instead?

Hi,

about 7 months ago I started working on https://github.com/Crazytieguy/gat-lending-iterator, before this crate existed on crates.io. I just now got around to publishing it, but then I noticed that this crate exists and is much more complete and has almost exactly the same design choices. The only major difference I'm noticing is the design around turning a lending iterator into an iterator, see https://github.com/Crazytieguy/gat-lending-iterator/blob/master/src/adapters/map.rs

If you think you'll be maintaining this one or are open to help I'll gladly yank mine 😄

Suggestion: highlight in the docs limitation of type inference when using IntoLender

We were writing a crate doing exactly what Lender does (https://crates.io/crates/hrtb-lending-iterator) because we didn't know about it. We're now using your crate instead. 🤷🏻‍♂️

One thing that might be confusing for the user is that when using IntoLender type inference doesn't work as expected and might give rise to weird errors. There's an example in the "Type-inference problem" section of the README of our crate. I couldn't find any warning about this problem in your docs, so you might want to add something about this.

Thank you for a great crate!