Coder Social home page Coder Social logo

autocrispy's People

Contributors

walkermx avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

autocrispy's Issues

Feature request: portable mode

Found no settings file on the folder so I figured it would be somewhere in Appdata. Since it's a single file for now it should be simple, but as I found multiple folders per version dunno if compatibility might become an issue.

Anyway, please see into making this tool portable as it matures, it fits it's pop n drop nature.

Thanks.

No Executable

The instructions say to Toss AutoCrispy into the folder from the backend(s) you chose, and run it., but there is no exe file in your repo. There's also no other type of script file that I've seen before, such as a .py file. If this program needs to be compiled before it can be ran, shouldn't the instructions say that? If it does not need to be compiled, what file specifically is supposed to be ran?

Feature request PCSX2EX support

Hello!

I love what you're doing, thanks a lot!

pcsx2ex creates a textures folder, then game id folder and dumps r8g8b8a8 dds files in there and it needs r8g8b8a8 or b8r8g8a8 dds files to replace as well.

It reads from gameid.yaml file from txtconfig folder. Its structure is basically this:

ProcessTEX:
  0xCBF51E7B: face.dds

no spaces ProcessTEXcomma enter
tab or double space 0casesensitivextexture'snamecomma space editedtexture.dds

note: notepad++ creates four spaces with tab and the yaml file needs two

Can you automate this process somehow? Thank you

Subdirectories output behavior improvement

Hi,

I noticed that AutoCrispy goes recursively into subdirectories when looking for files to upscale, however, output is put into the single directory. If subdirectories contain files with the same names output looks to be just overwritten.

So if you have structure like:

input_dir
- a.dds
- subdir1
--- a.dds
- subdir2
--- a.dds

You result will be just one a.dds in output directory and it will be the last one upscaled.

Would be nice to either be able to disable recursive directory scanning (as a minimal option) or for AutoCrispy to recreate same directory structure as input as an option (that would be probably better than just disabling recursive scanning, but requires more effort).

Normal maps

Hi, i'm having problems upscaling normal maps with texconv>SRMD>texconv. Low RGB values get premultiplied into normal map from alpha specular (for Skyrim). So the normal map ends up broken if specularity on alpha channel is dark. I tried every combination of texconv alpha settings but couldn't get this resolved.
I also have problems with resulting filenames, any longer name gets truncated like, for example: texturemain.dds filename gets truncated into textur~1.dds which makes batch conversion of certain files not practical.

Do Action Upon Texture Output

Hey while I was messing with your app, again lol, I thought of a feature that might be useful. I set up a batch script that presses a "reload texture replacements" (the replacements being the output of AutoCrispy) hotkey when the output folder gets new files in it. I do it this way because I only want it to reload if its in a new area with new textures. No point in inviting lag in when you don't have to.
I'm not sure if everyone does it this way, but I refresh my textures while I'm playing the game so having the ability for AutoCrispy to do/run something every so often when its outputting files might be useful. If its too much to add a "hotkey presser" into the app, maybe just a configurable field where you can type the path of an exe or something to be run every time the textures should be refreshed.
Thank you!

Feature request: folder support

As the backend support grows the folder where you run the application becomes a nasty mess of files, sometimes named the same. Dunno how hard it is, but allowing AutoCrispy to browse subfolders where you can set each one separatedly would be much better.

I think it can be done with generic folders? Even if not, you can add the names to the doc I guess, if it's a decent solution.

Thanks.

Autostart

Need a setting to autostart conversion process when launched, or a command line arg?

God tier app btw :)

Issues with Anime and RealSR backend

A continuation from this: https://old.reddit.com/r/emulation/comments/il0hdk/autocrispy_automatic_ai_upscaling/g3wyajf/

I did a clean install with the latest release (beta?) and most errors fixed themselves, every backend outside of those two worked right of the box and after changing the scaling factor. Didn't mess with other settings for now.

Anime still had the issue which we talked before - I set a file searcher to look for the output file name, and for working backends it first appears on temp folders, and after processing on the target folder as expected. Anime just quickly pops on the target folder and disappears, but even if saved there's clearly no processing done on such short time.

RealSR behaves as expected, but the output is black. There might be an issue with my setup, since I dropped everything in a folder and overwrote conflicts to test if the files are shared between backends Did a separate setup, no change. I'll file an correlated issue to it anyway.

Thanks a lot for being solicitous.

Fails to upscale after crash under certain conditions

Under certain conditions (unknown what causes it) if autocrispy crashes in the middle of processing an image, after that you can open the program but it will not process any more files.
I have tried Upscale Image, Batch processing, changing backends, Threads, In/Out folders, and delete all the files, re-downloaded everything with no luck.

It happened a couple months ago as well, after I reinstalled my OS I tried autocrispy again with the same files and it worked fine.

Support For Topaz AI

Hello again,
In tinkering with your app I found that no AI could compare to the one that I already had, Topaz Photo AI.
This is probably unnecessary for you to add but if it doesn't look like too much work, an official solution would be cool.
Can you make the name TPAI? Also if you need a picture for the chain slot I can make one!

The command I use is: tpai.exe -o "outputfolder" "input file or folder" (inputting by file in parallel seems to be fastest for this program)
No extra args are needed as the rest of the settings are inside of the app, so no extra settings are necessary on your end.
Here is the tpai.exe --help screen if anything does look like something you want to add as an option.
I also included a game asset I upscaled with Topaz at bottom if you were curious about the quality and my use case.
Thank you!


Options:
--output, -o: Output folder to save images to. If it doesn't exist the program will attempt to create it.
--overwrite: Allow overwriting of files. THIS IS DESTRUCTIVE.
--recursive, -r: If given a folder path, it will recurse into subdirectories instead of just grabbing top level files.
Note: If output folder is specified, the input folder's structure will be recreated within the output as necessary.
File Format Options:
--format, -f: Set the output format. Accepts jpg, jpeg, png, tif, tiff, dng, or preserve. Default: preserve
Note: Preserve will attempt to preserve the exact input extension, but RAW files will still be converted to DNG.
Format Specific Options:
--quality, -q: JPEG quality for output. Must be between 0 and 100. Default: 95
--compression, -c: PNG compression amount. Must be between 0 and 10. Default: 2
--bit-depth, -d: TIFF bit depth. Must be either 8 or 16. Default: 16
--tiff-compression: -tc: TIFF compression format. Must be "none", "lzw", or "zip".
Note: lzw is not allowed on 16-bit output and will be converted to zip.
Debug Options:
--showSettings: Shows the Autopilot settings for images before they are processed
--skipProcessing: Skips processing the image (e.g., if you just want to know the settings)
--verbose, -v: Print more log entries to console.
Settings Options:
Note: EXPERIMENTAL. The API for changing the processing settings is experimental and subject to change. After enabling an enhancement you may specify settings to override. Use --showSettings to see the names and auto suggested values for each setting.
--upscale: Turn on the Upscale enhancement. Pass enabled=false to turn it off instead.
--noise: Turn on the Remove Noise enhancement. Pass enabled=false to turn it off instead.
--sharpen: Turn on the Sharpen enhancement. Pass enabled=false to turn it off instead.
--lighting: Turn on the Adjust Lighting enhancement. Pass enabled=false to turn it off instead.
--color: Turn on the Balance Color enhancement. Pass enabled=false to turn it off instead.

Return values:
0 - Success
1 - Partial Success (e.g., some files failed)
-1 (255) - No valid files passed.
-2 (254) - Invalid log token. Open the app normally to login.
-3 (253) - An invalid argument was found.


exampleupscale

Seamless and Mirrored-Seamless modes (u/devilskin feature request)

The request was for adding 'Seamless' and 'Mirrored-Seamless' upscaling modes (similar to Joey Ballentine's 'upscale.py' script)

The goal is to correct Half- and Full-Pixel offsets that can result from upscaling, making seamless textures decidedly not seamless.

AutoCrispy Pathing Issue

Hello same issue happened to me! It seems when I try to upscale an image it tries to upscale every time an image that has failed.
AutoCrispy_uXabvOffZE

I tried to upscale a different image and saved it as exam room. But the error is stuck at justin serious.png

Originally posted by @Laezor in #7 (comment)

Can't select chains in Chaining tab when there's more than 6 chains

https://files.catbox.moe/k6u72h.mp4

Something breaks on the UI when there's enough chains to break them in 2 "pages". I can select the box and use arrows to get to/delete a chain, but clicking anywhere on that box does what you see in the video.

Maybe the vertical scroll is too much? Can't see a reason to add so many chains, but with all lined horizontally I think it's easier to understand the sequence in those cases. The horizontal scrollbar also fits nicely as is.

Saw the other features btw, good stuff.

Thanks.

Issue from devilskin (Reddit)

See the end of this message for details on invoking
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.ArgumentOutOfRangeException: InvalidArgument=Value of '0' is not valid for 'SelectedIndex'.
Parameter name: SelectedIndex
at System.Windows.Forms.ComboBox.set_SelectedIndex(Int32 value)
at AutoCrispy.Form1.Form1_Load(Object sender, EventArgs e)
at System.EventHandler.Invoke(Object sender, EventArgs e)
at System.Windows.Forms.Form.OnLoad(EventArgs e)
at System.Windows.Forms.Form.OnCreateControl()
at System.Windows.Forms.Control.CreateControl(Boolean fIgnoreVisible)
at System.Windows.Forms.Control.CreateControl()
at System.Windows.Forms.Control.WmShowWindow(Message& m)
at System.Windows.Forms.Control.WndProc(Message& m)
at System.Windows.Forms.ScrollableControl.WndProc(Message& m)
at System.Windows.Forms.ContainerControl.WndProc(Message& m)
at System.Windows.Forms.Form.WmShowWindow(Message& m)
at System.Windows.Forms.Form.WndProc(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

************** Loaded Assemblies **************
mscorlib
Assembly Version: 4.0.0.0
Win32 Version: 4.8.4200.0 built by: NET48REL1LAST_C
CodeBase: file:///C:/Windows/Microsoft.NET/Framework/v4.0.30319/mscorlib.dll

AutoCrispy
Assembly Version: 1.0.0.7
Win32 Version: 1.0.0.7
CodeBase: file:///D:/nn/AutoCrispy/ESRGAN-master/AutoCrispy.exe

Microsoft.VisualBasic
Assembly Version: 10.0.0.0
Win32 Version: 14.8.3761.0 built by: NET48REL1
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/Microsoft.VisualBasic/v4.0_10.0.0.0__b03f5f7f11d50a3a/Microsoft.VisualBasic.dll

System.Windows.Forms
Assembly Version: 4.0.0.0
Win32 Version: 4.8.4200.0 built by: NET48REL1LAST_C
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Windows.Forms/v4.0_4.0.0.0__b77a5c561934e089/System.Windows.Forms.dll

System
Assembly Version: 4.0.0.0
Win32 Version: 4.8.4200.0 built by: NET48REL1LAST_C
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System/v4.0_4.0.0.0__b77a5c561934e089/System.dll

System.Drawing
Assembly Version: 4.0.0.0
Win32 Version: 4.8.3761.0 built by: NET48REL1
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Drawing/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll

System.Configuration
Assembly Version: 4.0.0.0
Win32 Version: 4.8.4190.0 built by: NET48REL1LAST_B
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Configuration/v4.0_4.0.0.0__b03f5f7f11d50a3a/System.Configuration.dll

System.Core
Assembly Version: 4.0.0.0
Win32 Version: 4.8.4200.0 built by: NET48REL1LAST_C
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Core/v4.0_4.0.0.0__b77a5c561934e089/System.Core.dll

System.Xml
Assembly Version: 4.0.0.0
Win32 Version: 4.8.3761.0 built by: NET48REL1
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Xml/v4.0_4.0.0.0__b77a5c561934e089/System.Xml.dll

Accessibility
Assembly Version: 4.0.0.0
Win32 Version: 4.8.3761.0 built by: NET48REL1
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/Accessibility/v4.0_4.0.0.0__b03f5f7f11d50a3a/Accessibility.dll

System.Runtime.Remoting
Assembly Version: 4.0.0.0
Win32 Version: 4.8.3761.0 built by: NET48REL1
CodeBase: file:///C:/Windows/Microsoft.Net/assembly/GAC_MSIL/System.Runtime.Remoting/v4.0_4.0.0.0__b77a5c561934e089/System.Runtime.Remoting.dll

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.

Issue from TomLube (Reddit)

************** Exception Text **************
System.ArgumentOutOfRangeException: InvalidArgument=Value of '3' is not valid for 'SelectedIndex'. Parameter name: SelectedIndex at System.Windows.Forms.ComboBox.set_SelectedIndex(Int32 value) at AutoCrispy.Form1.Form1_Load(Object sender, EventArgs e) at System.EventHandler.Invoke(Object sender, EventArgs e) at System.Windows.Forms.Form.OnLoad(EventArgs e) at System.Windows.Forms.Form.OnCreateControl() at System.Windows.Forms.Control.CreateControl(Boolean fIgnoreVisible) at System.Windows.Forms.Control.CreateControl() at System.Windows.Forms.Control.WmShowWindow(Message& m) at System.Windows.Forms.Control.WndProc(Message& m) at System.Windows.Forms.ScrollableControl.WndProc(Message& m) at System.Windows.Forms.Form.WmShowWindow(Message& m) at System.Windows.Forms.Form.WndProc(Message& m) at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m) at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m) at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.