waddlesplash / haiku-kitchen Goto Github PK

This might allow getting rid of some of the callback hell.

There is no reason to hide things under a docs directory. You can link to the design document under docs/.

It appears packages get downloaded over and over (even if not needed)

This is a whole lot of code without any tests. Both the client and server should have a good test suite.

While the documentation covers creating a ssh key, it doesn't mention how to start the server.

The installation documentation mentions files that don't exist within the tree "... and place it in the data folder alongside builders.json."

There is a race condition where a build is attempted to be scheduled across two build slaves resulting in a crash.

 kitchen:builds build #78 succeeded! +44s
  kitchen:builders updating haikuporter/haikuports trees on kallisti5-x86_64-1 +961ms
  kitchen:builds failed to schedule build [79]: no matching builders +1ms
  kitchen:portstree saved cache to disk successfully. +952ms
  kitchen:builds starting build #80 on builder 'kallisti5-x86_64-1'... +280ms
TypeError: Cannot set property 'exitcode' of undefined
    at commandFinished (/builds/kitchen/server/builds.js:149:18)
    at Builder._handleMessage (/builds/kitchen/server/builders.js:228:6)
    at TLSSocket.<anonymous> (/builds/kitchen/server/builders.js:428:14)
    at emitOne (events.js:96:13)
    at TLSSocket.emit (events.js:188:7)
    at readableAddChunk (_stream_readable.js:176:18)
    at TLSSocket.Readable.push (_stream_readable.js:134:10)
    at TLSWrap.onread (net.js:547:20)

Haikuporter buildmaster has a flag to choose the prefix path for data storage. It would be nice if kitchen had this.

Example:

   node index.js --prefix=./data
   node index.js --prefix=/builds/data

Issue

On a new builder, every port failed due to kitchen not downloading libpng16 needed for freetype.

Workaround

Manually download https://vmpkg.haiku-os.org:5825/libpng16-1.6.29-2-x86_gcc2.hpkg into haikuports packages directory on builder.

Had a qemu builder go up to 100% cpu and lock up. Looks as though the git repo got corrupted which caused kitchen to show a red x for the builder post=reboot.

It might be nice to have a remote "reset" call to erase the build directories and reconfigure the node.