w3champions / identification-service Goto Github PK

Not sure what is causing this, but ID service is returning 401 for website logins.

Logs from ID service of this happening attached.

401error.txt

?jwt=undefined application/json

looks a bit strange to me?

We have need shortly for a permissions system on the website. I thought I'd start this as a topic for discussion. I'll be trying to look into how to do this soon.

I think this is going to require a new JWT claim, so my suggestion is a "permissions" or "roles" claim inside the JWT that contains enum mappings for permissions.

something like:

"roles": [
  {
    "name": "admin",
    "permissions": [
       {
         "name": 0 // which maps to an enum for that permission
       },
       ...
    ]
]

Permissions we would need are:

• global or "root" permissions granting all permissisons.
• creating/editing automated tournaments for a game mode.
• banning players for a game mode (I guess we can include all of melee for this).
• adding new maps (a one-day feature I think)
• some kind of global "flo" permissions, at the moment used for assigning proxies to bnet tags
• Data scientist role (currently used for looking at queue data)

Some potential issues I see:

• Our expiry for JWTs is functionally never, I assume we would need to regularly refresh tokens to update permissions? maybe once every day or so?
• We'll probably have to make a new secret, which means breaking everyones oauth. If we anticipate this right and only require a one-off sign in again.