Comments (5)
@sam-vi thoughts on this? Should we discuss it at the next meeting perhaps?
from webrtc-pc.
This dictionary is also used as a method argument in webrtc-extensions. How would that be affected?
from webrtc-pc.
I think the goal would be for selectCandidatePair and removeCandidatePair to take the interface object (instead of a dictionary with two member interface objects).
The two methods throw NotFoundError
on invalid pairs already. Pairs serve as handles to resources effectively.
I didn't find any WPT tests for these methods, so they're hopefully not implemented yet @sam-vi is that right?
from webrtc-pc.
Pairs serve as handles to resources effectively.
Not in an owning way, I should say. E.g. we could have used IDs for this instead, but interface objects seem better.
from webrtc-pc.
@sam-vi thoughts on this? Should we discuss it at the next meeting perhaps?
I agree with this proposal. I will work on some next steps.
This seems like a mistake, allowing JS to compose invalid pairs and pass them as inputs.
I can't be certain about the motivation for the original definition as a dictionary. But I imagine that prior to selectCandidatePair and removeCandidatePair, when the only use of RTCIceCandidatePair was as a return value for getSelectedCandidatePair, a less restrictive definition was adequate and there was no possibility of misuse of a malformed candidate pair.
I think the goal would be for selectCandidatePair and removeCandidatePair to take the interface object (instead of a dictionary with two member interface objects).
+1. With [[CandidatePairs]], it is also possible to avoid pitfalls such as #2906.
I didn't find any WPT tests for these methods, so they're hopefully not implemented yet @sam-vi is that right?
Correct. I recently got back from parental leave. I will continue work on the implementation and next steps for the spec.
from webrtc-pc.
Related Issues (20)
- Adding and stopping transceiver before first offer will result in unremovable transceiver HOT 3
- QUIC as Transport for Session Traversal Utilities for NAT (STUN) HOT 3
- Modify the codec description model to ease describing changes HOT 5
- Applying a remote offer with unsupported codecs results in stale transceiver HOT 2
- Should media capabilities influence what is exposed in what is exposed in WebRTC offers and answers HOT 13
- Update the accessibility section 14 to include RFC 8865 for real-time text in WebRTC data channel HOT 43
- Clarify a=rtpmap codec mappings should be offered even if the codec is not a preferred one HOT 20
- Existing setCodecPreferences NOTE is wrong and should be deleted HOT 8
- Specify what should happen if filtering [[PreferredCodecs]]Β on direction results in empty list HOT 7
- setCodecPreferences, sendonly codecs and dummy codecs HOT 21
- If a preferred codec is filtered out, does it still get assigned a PT? HOT 16
- Proposing setCodecPreferences to deal with both send and recv codecs HOT 6
- RTCSessionDescriptionInit vs "local" RTCLocalSessionDescriptionInit HOT 2
- Review mute/unmute/ended and constraints on RTCRtpReceiver's track. HOT 2
- Alternative storage for RTCCertificates needed HOT 6
- simple webrtc connection and manual signaling (QR, JSON, Carrier pigeon) - consent time out prevents connection HOT 3
- RTCIceCandidate's relayProtocol and url members can be null but not absent
- Missing tests for candidate amendments
- Incorporate jitterBufferTarget
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from webrtc-pc.