Coder Social home page Coder Social logo

Comments (5)

fippo avatar fippo commented on July 23, 2024

The current situation is indeed not good. When adding codecs that are rarely used like H264 with 444 they get added to the SDP, consuming a payload type and increase the size of the SDP (and remember that we had a comparison between the WebRTC SDP and the Empire State building in one slide deck).

setCodecPreferences can be (somewhat) used to limit this but it requires action.

from webrtc-pc.

alvestrand avatar alvestrand commented on July 23, 2024

If we allow setParameters() to enable a disabled codec (https://w3c.github.io/webrtc-extensions/#dom-rtcrtpencodingparameters-codec), the only missing piece is discoverability.
And in simulcast, we deferred discoverability to MediaCapabilities (decodingInfo with "webrtc" - ask, and you shall learn). If we were to address the bug asking for CodecCapability, perhaps we have all the pieces?

from webrtc-pc.

alvestrand avatar alvestrand commented on July 23, 2024

I'll ask for this issue to be discussed at the February WG meeting, since I feel that doing this will make resolving our other issues easier, but want to have WG consensus on the approach before preparing the PR.

from webrtc-pc.

henbos avatar henbos commented on July 23, 2024

Moving the check from the checking a global state to checking a sender/receiver state, in order to unblock changing sender/receiver capabilities, makes sense to me.

If a codec in a remote offer or answer is on the supported list, but “enabled” is false, “enabled” is set to true. This ensures that the codec is included in subsequent offers and answers. (Note: This is the only part of this reimagining that might include a behavior change, but we suspect that this is the way current implementations behave anyway.)

I think we need to do this for unidirectional codecs anyway? Hopefully we already do it

The final steps to create an offer or answer is not influenced by the current negotiation state, but there is a NOTE in the setCodecPreferences section suggesting that answers should only have codecs that appear in the offer.

I think this NOTE is wrong and should be deleted (#2933). I also think there is some major confusion about a=rtpmap versus preferences (at least for me, but maybe it's crystal clear for everyone else), so I filed #2932. I also think that Fippo's PR needs to remove this sentence from createAnswer. Does that make sense to everyone or am I still confused?

from webrtc-pc.

dontcallmedom-bot avatar dontcallmedom-bot commented on July 23, 2024

This issue was discussed in WebRTC February 2024 meeting – 20 February 2024 (Modify the codec description model to ease describing changes #2925 #2935)

from webrtc-pc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.