w-martin / mindfulness Goto Github PK

For conda requirements

b'Dream Theater - The Dance Of Eternity\n'

Potential fixes: decode utf8, or strip

[2017-12-04 15:56:18,526] ERROR in app: Exception on /add-entry/ [POST] Traceback (most recent call last): File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1982, in wsgi_app response = self.full_dispatch_request() File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1614, in full_dispatch_request rv = self.handle_user_exception(e) File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1517, in handle_user_exception reraise(exc_type, exc_value, tb) File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1612, in full_dispatch_request rv = self.dispatch_request() File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1598, in dispatch_request return self.view_functions[rule.endpoint](**req.view_args) File "/opt/mindfulness/src/web.py", line 67, in add_entry database.add_song(db, link, song, user_id, month=12 if festive else None) File "/home/datascience/PyCharm/mindfulness/src/database.py", line 115, in add_song db.execute(query_str) ProgrammingError: syntax error at or near "Christmas" LINE 1: ...ngs (title,url,user_id) select 'Do they Know it's Christmas ...

Like...Friday.

Allow users to mark themselves as 'on holiday' so that their songs won't play

To prevent csv fields from crossing over into others

Suggested by @tomwdrake

Suggested by @tomwdrake

For 're-run' situations

Songs are typically specified as " - <Title>". However, in the discord mindfulness notification, they appear without this hyphen separating artist and title, making the text harder to parse.

Suggested by @tomwdrake

To avoid iterating through the same user's songs daily

because it's also used for our morning standups, verv's office speaker is usually set to max volume. this is too high for most downloaded songs; they usually come out noisy and sound a bit distorted

Too many -1's and the song is removed. No more green day please

Accidental merge sigh so I'll just file this bug report. Once this is resolved I'll release v1.1 and put the system live

This would be helpful logging, as well as the song before it plays

grep ',False' playlist.csv | wc -l

Songs count on web page seems to include the header row

Web page will get more hits during mindfulness, display the currently playing song

Instead of csv

Suggested by @tomwdrake

Dependency missing

[2018-03-12 15:14:49,826] ERROR in app: Exception on /add-entry/ [POST]
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1982, in wsgi_app
response = self.full_dispatch_request()
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1614, in full_dispatch_request
rv = self.handle_user_exception(e)
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1517, in handle_user_exception
reraise(exc_type, exc_value, tb)
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1612, in full_dispatch_request
rv = self.dispatch_request()
File "/usr/local/lib/python2.7/dist-packages/flask/app.py", line 1598, in dispatch_request
return self.view_functionsrule.endpoint
File "/opt/mindfulness/src/web.py", line 61, in add_entry
song = util.remove_commas_from_string(request.form["songName"])
File "/opt/mindfulness/src/util.py", line 27, in remove_commas_from_string
return str(input_string).translate(None, ',')
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe9' in position 1: ordinal not in range(128)

Since YT link is being inserted as a string, input sanitation (or lack thereof) does not filter the nasty symbols out, allowing shell commands to be executed.

E.g. ; cat /etc/fstab >> /home/datascience/fstab -- will do cat /etc/fstab >> /home/datascience/fstab: semi-colon ends the youtube-dl part and -- escapes the --no-warnings suffix.