vxnick / abilitytrader Goto Github PK

Which doesn't work if the abilities have uppercase characters in the config

Apparently, the command name resolves any aliases but the label doesn't.

If an ability is given to a player by an administrator, it's logged as the player purchasing or renting the ability themselves.

If the user is not online at the time a rental expires then the ability is not removed.

AbilityTrader goes through the motions of removal and removes the user from the list so it is never checked again (they are no longer in the list as having the ability rented) and thus is never removed.

I'm trying to rent out abilities for 18 hours at a time (basically 1 day rental) and this is an issue. Would be an issue on any time rental if users were aware of it.

I suggest a check to see if the user is online before continuing to process the removal. If they aren't online just leave them in the list for removal later.

Allow reload to be run via the console as well as by a player.

The command "/ability add" would allow an admin to give people ability rentals without them having to pay for it. There are a few applications:

• Free trials of abilities. Instead of just giving them the permissions directly the AbilityTrader system could ensure the trial ended after the normal period.
• Allowing admins to grant a limited set of permissions on people instead of giving them access to your whole permissions plugin
• Donator perks. This way a donation system could run "/ability add" to automate the process of adding limited-time perks.

Additionally, the command could have another parameter that does automatically charge the player as if they had bought the ability normally. This could be used to allow people to buy abilities via Citizens while denying them permissions to access the /ability commands directly.

Log ability purchases and removals (both expiry and via player).

Something like ab and at

If this is enabled, messages will be logged to console (for example, "player has rented X ability").

Can you use a real money purchase system to give the ability to purchase protections of areas without factions.

Example, I want to ensure no one can break my build; the build is 10444 blocks large, I buy on Paypal or some other system protection for 10444 blocks and use them via WE or /cprotect in game.

Also, Can you "buy " Creative mode for X time?

If so how?

Thanks Lorin' of Server Lorin'
www.lorin.enjin.com

Abilities with durations in hours are showing as days

The task isn't calling saveConfig() once it's removed abilities

Create a sub-list within the ability commands string list to allow for different commands to be executed when adding and removing abilities.

Expired abilities are still shown on the info screen because the task hasn't run yet. Run the task when showing the info screen.

Specify a list of groups that a player has to be in before an ability can be displayed/purchased, and groups to move the player into upon purchase/removal.

Doesn't allow for decimal places

Allow for a both ability type. Both prices should then be displayed on the list screen.

The cost should be modified to allow for a buy_cost and rent_cost. This won't affect player data as an expiry always applies to a rentable ability.

Include the duration if applicable

Identical to ability commands, but runs for all abilities

Ability attributes, etc

The ability screen is pretty sparse - add the description to each ability.

Show the player a message when abilities are close to expiry, if they're online

There are some checks that determine whether a player already has a permission - in some cases there may not be any permissions, so this could cause an error. Investigate