oauthgistgithub's People
oauthgistgithub's Issues
Code Review
A crash on this line:
The following code I'd rewrite:
OAuthGistGitHub/GistApp/GistsList/Service/GistsViewModel.swift
Lines 14 to 37 in ec1dbce
class GistsViewModel {
private let keychain = KeychainManager.sharedKeychainWrapper
func loadGists(completion: @escaping ([Gist]) -> Void){
let url = URL(string: Constans.url)!
let headers = ["Authorization":"token \(keychain.string(forKey: "access_token") ?? "")"]
Alamofire.request(url, method: .get, parameters: nil, encoding: JSONEncoding.default, headers: headers).validate().responseData { (data) in
switch data.result.flatMap({ try JSONDecoder().decode([Gist].self, from: $0) }) {
case .success(let gists):
completion(gists)
case .failure(let err):
completion([])
print("Gists uploading error \(err)")
}
}
}
}
Note:
- there is no reason to keep
gists
in the model (at least you don't use it anywhere) - you can guarantee that the
url
is correct, hence force unwrap it - usage of
flatMap
with decoding for a result completion
is called in both success and failure branches. What if a user of this code wants to show a spinner and hide it on completion?
Other improvements could be: propagate errors to the caller, for example using Result<[Gist]>
in completion
Seems like you don't need isFirstLoading
here:
OAuthGistGitHub/GistApp/GistsList/View/GistViewController.swift
Lines 28 to 30 in ec1dbce
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.