vsternbach / angularjs-testbed Goto Github PK

The devDependency jasmine-core was updated from 3.4.0 to 3.5.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

jasmine-core is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

There have been updates to the angular1 monorepo:

• • The devDependency angular was updated from 1.7.8 to 1.7.9.

• The devDependency angular-mocks was updated from 1.7.8 to 1.7.9.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

This monorepo update includes releases of one or more dependencies which all belong to the angular1 group definition.

angular1 is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

When using in my unit test I have the following errros:

31 07 2018 13:57:04.950:ERROR [compiler.karma-typescript]: node_modules/angularjs-testbed/types/ComponentFixture.d.ts(17,26): error TS2304: Cannot find name 'JQLite'.

31 07 2018 13:57:04.950:ERROR [compiler.karma-typescript]: node_modules/angularjs-testbed/types/DebugElement.d.ts(1,23): error TS2688: Cannot find type definition file for 'jquery'.

31 07 2018 13:57:04.950:ERROR [compiler.karma-typescript]: node_modules/angularjs-testbed/types/DebugElement.d.ts(3,27): error TS2702: 'JQuery' only refers to a type, but is being used as a namespace here.

31 07 2018 13:57:04.951:ERROR [compiler.karma-typescript]: node_modules/angularjs-testbed/types/DebugElement.d.ts(5,39): error TS2304: Cannot find name 'JQLite'.

31 07 2018 13:57:04.951:ERROR [compiler.karma-typescript]: node_modules/angularjs-testbed/types/DebugElement.d.ts(7,21): error TS2702: 'JQuery' only refers to a type, but is being used as a namespace here.

Maybe the required @types should be added as dependencies or at least peerDependencies?

This does not seem to work:

interface IFooResource extends ng.resource.IResourceClass<IFoo> {}

function FooResource($resource: ng.resource.IResourceService) {
  return $resource('/foo/:id', {
    format: 'json',
    id: '@id'
  });
}

describe('FooResource', () => {
  let resource: IFooResource;

  beforeEach(() => {
    TestBed.configureTestingModule({
      imports: [
        ngResource
      ],
      providers: [{
        provide: 'FooResource',
        useFactory: ($resource) => FooResource($resource),
        deps: [
          '$resource'
        ]
      }]
    })
    .compileComponents();

    resource = TestBed.get('FooResource');
  });
});

it gives a Error: [$injector:unpr] Unknown provider: FooResourceProvider <- FooResource error.

Maybe there is another way to import the resource?

The devDependency tslib was updated from 1.9.3 to 1.10.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

tslib is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency coveralls was updated from 3.0.3 to 3.0.4.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

coveralls is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency @types/angular was updated from 1.6.54 to 1.6.55.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/angular is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency rimraf was updated from 2.6.3 to 2.7.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

rimraf is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

The devDependency @types/jquery was updated from 3.3.29 to 3.3.30.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/jquery is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

The devDependency copyfiles was updated from 2.1.0 to 2.1.1.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

copyfiles is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Your Greenkeeper Bot 🌴

Hi, I have a component which depends on ngModel controller, here is my implementation:

import { Component, ViewParent, Input } from 'angular-ts-decorators';
import { INgModelController }           from 'angular';

@Component({
	selector: 'connect-content',
	template: require('./connectContent.tpl.html')
})
/*@ngInject*/
export class ConnectContent {
	@ViewParent('ngModel') ngModel: INgModelController;
	@Input() connectContentId: string;

	constructor () {
	}
}

When I try to create the test instance of this component via TestBed.createComponent(ConnectContent) in my test suite I get a self-explanatory error:

Error: [$compile:ctreq] Controller 'ngModel', required by directive 'connectContent', can't be found!
	https://errors.angularjs.org/1.7.5/$compile/ctreq?p0=ngModel&p1=connectContent

As I've looked into your (wonderful btw) library's code I see the require property is not taken into account at all when compiling directive inside of _compileComponent function.

Is there any working path to get around this?
If not how do you think that one should be tackled? While adding dumb attributes based on requires and passing some empty values to them can be an option it might not work (based on component's logic).
Another way would be to prepare non-standard (for Angular2+) method for passing object containing attributes names & values. But I don't know if tricks like that are supposed to be inside of angularjs-testbed library :<