vrsys / guacamole Goto Github PK

It would be nice to have an install target for avango.

Most of files in the repository have correct Unix-style endings (LF), but some files have DOS endings (CRLF). It is even possible to find mixed files. This inconsistency may cause problems in some text editors.

Probably it is better to have the same endings everywhere.

I commented out some Video3D stuff in 0ec3d76, since it does not work with multiple materials somehow.

Pipeline::print_shaders() definition missing since 976b2f9. Currently it seems impossible to extract shader code at runtime.

We could call it the "GuaSL Spec" ;-)

Assigned to Adrian.

TriangleMeshShape::FromGeometryFile() doesn't consider rescaling/positioning introduced by GeometryLoader::NORMALIZE_POSITION and GeometryLoader::NORMALIZE_SCALE
This may lead to wrong collision behaviour after loading TriangleMeshShapes with those flags!

avango.gua.PickResult does not return correct WorldPosition of intersection point

Ressource Compiler handles temporary files, this results in a wrong R.inl Ressource file.

Avoiding files with temporary file endings (like .frag~) could avoid that.

Commonly instantiation for ressources is NOT thread safe! 👍
if (ressource_container.size() > ctx.id) {
return;
} else {
ressource_container.resize(ctx.id);
// initialize ressources for ctx.id
}

BETTER (but also not entirely safe as it resize is required to be thread-safe) :
if (ressource_container.size() > ctx.id) {
if (ressource_container[ctx.id]) { // for pointer semantic
return; // pointer for ressource is valid -> return
} else {
// pointer is not initialized -> continue initialization
}
} else {
ressource_container.resize(ctx.id);
}
// initialize ressources for ctx.id

Not compiling anymore...

We should change the names of our find scripts, e.g. change find_openal.cmake to FindOpenAL.cmake.

Also cmake already provides alot of scripts which can be used with find_package.

e.g. vec * vec

• cmake changes crash on windows build
• master is commits ahead of develop! we should only have a stable version on master and work on develop!

Assigned to Carl.

It has to be possible to tell which branches (or at least tags) of all guacamole repositories (guacamole, examples, editor, oculus & avango-gua) are compatible.

I propose the following:

• master branch of all repos should be in sync
• develop as well

Therefore: Before merging a feature branch, it needs to be tested against current development state in all other repos!

Are there any thoughts on this issue? Other strategies?

Running an application with multiple avango.gua.gui.nodes.GuiResource() more than once causes segmentation faults.
Whenever I run my app it only works one time. After closing it in the console with ctrl+c and starting it again it crashes with a segmentation fault. Changing something in the code fixes the bug for one more run, then I get the same error again.
Sometimes it even crashes on the first run.
To me it seems like something is not destructed the right way.
I am using different names for every GuiResource.

The current implementation of one taglist for both rendering and picking causes unwanted interferences, especially when using whitelists.

Maybe something like dfs_traverse and visible (or cull).

Similar to filtered from boost::range:
http://www.boost.org/doc/libs/1_55_0/libs/range/doc/html/range/reference/adaptors/reference/filtered.html

according to the header in the first source file I looked at this project is GPLv3+ licensed. Please make this information easier to find by adding a LICENSE file in the root directory.

geometry nodes not visible when attached to screen node
(geometry nodes attached to eye works)

Add possibility to render a test image into a file.

Does schism support p-buffers?

We should host the doxygen generated documentation for the master branch on github pages. A new branch called gh-pages is used to publish the project site.

See: http://pages.github.com/

Add a template and a small howto.

Update the Find***.cmake script according to: http://www.cmake.org/cmake/help/v2.8.8/cmake.html#command:find_package

Then we can use find_package(Assimp)

"CMake searches for a file called "Find.cmake" in the CMAKE_MODULE_PATH followed by the CMake installation"

Memory allocated by KDTree::build() is never deallocated.

normalize on avango.gua.Vec3(0.0,0.0,0.0) returns nan

Tests are still missing.

The cmake/modules/find***.cmake file are using hard coded paths which can't be override with ccmake.

In UniformMapping::add() uniforms of same type are currently pushed into static array.
For >500 materials (e.g. in medieval harbour) these arrays become too large! Shader compilation fails.
As a solution use a UBO or samplerBuffer instead!