vram-guild / json-model-extensions Goto Github PK

I can't seem to use RetexturedModelBuilder to copy a model from an item to another custom item. Here is an example project where the issue occurs.

Re-producing:

1. registered 2 custom items, 1 of which has a working item model/texture
2. called the RMB as I would for blocks:
   RetexturedModelBuilder.builder("minecraft:allium", "jmxtesting:my_item2") .mapSprite("block/allium", "block/allium") .completeItem();
3. loaded in after confirming the missing model error is gone from console

Additional tests:
I tried copying the custom item's model to the second unmodeled custom item, with the same result: no error, but no textures. Blocks work fine with this same setup, so I wonder if I made a sprite identifier error.

Logs/images:
Here is an image of items 1 and 2, the second of which is supposed to have the allium model:
. Pastebin of log is here-- nothing off or wrong.

Versions:
JMX: 0.2.3+build.45
Minecraft: 1.14.3
API: 0.3.0+build.187
Loader: 0.4.8+build.155

I'm guessing it's some sort of silly "wrong namespace" error on my part, but haven't been able to figure it out. Thanks in advance!

CrashLogs: https://bytebin.lucko.me/oro6DRIztP
LatestLogs: latest.log

Taking the mod Indium out works but having the Indium mod crashes

When using jmx to render a block with both translucent and cutout textures, water which is in the same chunk and has a larger z coordinate than the block in question may not be rendered.

here's the json model for one such block
https://hastebin.com/usugirejes.json

all of the blocks in question return BlockRenderLayer.CUTOUT in getRenderLayer()

Minecraft: 1.14.3
fabric api: 0.3.0+build.187
jmx: 0.2.3+build.45

As stated with the title, when I use any shader with the latest version of this mod, there's a filled-in white box around the torch. I'm not sure why, but I'm certain this mod causes it.

Hey there, was excited to try your mod with my JSON models since I noticed in the wiki there seems to be an "emissive" option to use, but I couldn't get my client to launch with the mod installed!

As stated in the title, it seems the mod crashes with the latest Fabric API and Fabric Loader
mappings: 1.14.2+build.7
loader version: 0.4.8+build.155

https://pastebin.com/cJK3vXCQ

See screenshot in #2

When loading a JMX model defined without a materials element, as shown here, a null pointer exception is thrown. This happens because when the extension data is being deserialized, JMX does not check whether or not these keys are present.

Crash report available here (generated via a mixin since the exception is normally caught).

The original bug was reported here

Shnupbups/extra-pieces#6 (comment)

The author indicated that the problem was likely with JMX, They ask that I post a report here.

The specifics are that a change in the version of extra-pieces resulted in the problem.

To see what the effect are reference back to the original bug report.

For more information let me know if there is anything that I can add to help resolve this problem.

The details here are sparse but more complete in the original report.

Would it be possible to add rotating model smaller increments than 90 via blockstate?

Basically what it says on the tin—I'm going to be digging into the Item Model generation and rendering code myself when I have time, so I'll post any pointers here ig?

Crash Report: https://pastebin.com/J3TmrHN2
Latest.log: https://pastebin.com/VGeh0p57
Only mods installed are Fabric API(0.45.0+1.18), Indium(1.0.2-alpha1+mc1.18), JSON Model Extensions(1.22.243), Mixintrace(1.1.0), and Sodium(0.4.0-alpha5+build.9).