Support pg.js about node-connect-pg-simple

[voxpelli]

Hadn't seen the "pg.js" variant actually – great that you point it out!

It has always been possible to supply a driver of ones own and it is recommended that one do as that enables all parts of the program to share the same connection pool etc. The included pg library is just a fallback for the cases where postgres isn't used for anything but the sessions.

I would propose just changing the fallback library from "pg" to "pg.js" entirely and let anyone who want a the more performant compiled library to supply it themselves (as they are hopefully already doing if they have an app that needs the performance).

Does that sound like a good solution?

[rauno56]

I actually think it's a great compromise to be made here. I approve.
But IF we are going to break the backwards compatibility with #6 anyways I would also throw out the dependency(change it to devdep).

[voxpelli]

I think the benefit of being able to include the session module with as little configuration as possible outweighs the benefit of having one extra dependency, especially now when that dependency doesn't have to be compiled.

A minor bonus is that the dependency also documents what API of the pg/pg.js modules it is that the module support.

Apart from just switching from "pg" to "pg.js" I also flagged the 3.x versions of the modules as being compatible as none of the breaking changes in the major version there broke anything for this module.