Comments (7)
In that case, I will open a PR. Thanks
from node-connect-pg-simple.
Fixed in ea4a9c1
from node-connect-pg-simple.
Released as 9.0.1
from node-connect-pg-simple.
I came here to report the same issue, but decided to check first for a possible explanation.
Why was this issue closed as completed? The @types/pg
dependency is still present...
from node-connect-pg-simple.
@kylewillmon I cannot remember why I decided to do it. Possibly due to that having it as a production dependency means it gets shipped as part of the npm install
done by projects, so they can reference types directly e.g. via JSDoc comments as TypeScript or similar. Without having to install @types/pg separately. But I assume having it separate is still wanted.
An even better solution imo would be to bundle the declaration files in this repo and ship them with the installation, as the DefinitelyTyped (@types) repo is often considered a "backup" in case projects do not have their own types. Having types in the actual main project is preferable and recommended afaik.
🤷
from node-connect-pg-simple.
The type situations around express session has been a bit messy. I think I added it as a dependency
as I normally try to publish types for my modules, but for this module I haven't yet gotten to that
from node-connect-pg-simple.
It was moved there in 7d20257, but I can't find a justification for doing so 🤔
from node-connect-pg-simple.
Related Issues (20)
- Update deps? HOT 3
- Manage user sessions [question] [help wanted] HOT 4
- createTableIfMissing not working HOT 17
- Error thrown when setting a session when connecting to Heroku-hosted PostgreSQL HOT 2
- Use ES6 import HOT 3
- Change `pg` to a peer dependency HOT 2
- db.bit.io issues HOT 8
- 'Failed to prune sessions: con.connect is not a function' when trying to connect PostgreSQL database with session store via Knex.js HOT 1
- error: date/time field value out of range: "1655239143" HOT 4
- Failed to prune sessions: relation "session" does not exist HOT 3
- Two sessions being saved to store HOT 1
- If at the first try to create the session table the database is down, the store fails forever HOT 3
- Getting error "Error: connect ECONNREFUSED ip_address:5432" intermittently when the RDS is restarted.
- Getting error "Error: connect ECONNREFUSED ip_address:5432" intermittently when the RDS is restarted. HOT 2
- Unexpected token in node_module index.js HOT 2
- Using "pruneSessionInterval=false" will unexpectedly disable "createTableIfMissing=true" HOT 3
- Property "replaceAll" does not exist on type "string". HOT 4
- pg-simples tries to access wrong column HOT 1
- createTableIfMissing is not working in version: 9.0.0 HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from node-connect-pg-simple.