The backend from voteamerica

Confirming a match redirects to strange text

This is the case for all ride management links in emails. Please change the text to the following:

1

Driver accepts match

We have let [rider name] know that you have accepted their request for a ride. [Rider name] is now waiting for you to get in touch to arrange the details of the ride.

Please contact the rider as soon as possible via [preferred contact method].

We have sent your an email [and SMS, if applicable] notification confirming this information. If you do not receive this, please contact customer support: 804-239-3389

2

Rider cancels specific ride match (NOT entire ride request)

We have let [Drive Name] know that you no longer need a ride from them. Our system will keep trying to find you a match.

Carpool Vote cannot guarantee that there will be another match, or that another driver will provide a ride as agreed. Please keep looking for a ride until you have reached your destination.

If this was an error, please contact user support on 804-239-3389.

3

Rider cancels entire ride request

Your request for a ride has been cancelled. If you had already been matched with a driver, we've let the driver know that you no longer need a ride.

You can reactivate the request through the self-service portal [please include link to specific UUID login] or by calling 804-239-3389. You can also sign up again on CarpoolVote.com.

4

Driver confirms match but it's no longer available

Thank you for offering to help! This rider no longer needs a ride. We'll let you if anything changes.

5

Driver cancels specific ride match (NOT entire ride offer)

We have sent [Rider Name] a notification that you are no longer able to offer them a ride. If their preferred contact method was phone, we ask that you also let them know in this way, as our system does not currently support voice notifications.

Our system will keep trying to find the rider another match.

If you cancelled the ride offer in error, please contact rider to let them know.

Remove rider identifying details (name, contact details) from proposed matches in self-service portal

This should only become visible once match has been accepted.

Add full ride request details to self-service portal suggested and confirmed matches

Please:

Available ride times
Add "(preferred)" next to the preferred contact method; remove this from the line containing the accommodation notes
Add power chair adapted vehicle needed, where this applies
Add number of seats required
Specify whether 2-way trip is needed

Also separate SMS and notes into 2 separate lines (currently they appear next to each other, and look squashed/confusing)

Log IP Address from request, and not from a form field.

Should log client's IP Address, rather than some form field. (So that we know where it came in form).

http://stackoverflow.com/questions/19266329/node-js-get-clients-ip

Rename db/carpool_db_schema.txt to db/carpool_db_schema.sql

Pause Match Driver feature

@jkbits1 See new USER STORY 016
I'll have the procedure ready soon.
And I need to update a few e-mail notifications to include the new link

Ride request and drive offer SMS has cancel link

I imagine this would result in some unintended actions (I thought we'd removed these?)

Please could we remove the cancellation link from both ride request and drive offer notification text messages?

Driver accepted match SMS notification doesn't include rider contact details

Please add rider contact details to SMS notification that the driver receives after confirming a match. We do not want to risk them forgetting to get in touch with the rider.

Please also do the same the other way around. I.e., send the rider the driver's contact details (in case there's an issue with the driver getting in touch).

Rider/Driver submissions from form fails if some non-required boxes are not checked.

For Example:

rider row insert failed: null value in column "TwoWayTripNeeded" violates not-null constraint.

What should happen:
The backend node app should check for existence / provide default (false/0) values for the data elements which are being inserted.

Those include:
DrivingOnBehalfOfOrganization (default false)
WheelchairCount (default 0)
NonWheelchairCount (default 0)
TwoWayTripNeeded (default false)
DriverEmailValidated (default 0/false?, until validated by confirming/responding to Email.)
DriverPhoneValidated (default 0/false, until validated by confirming/responding to Text.)
ReadyToMatch (default 0)
PleaseStayInTouch (default 0)

Add rider needs to redirect browser

see voteamerica/voteamerica.github.io#257 for details

Change "Cancel drive offer" link to "Pause notifications" link in driver notifications

This way, the driver won't be disturbed by notifications but can still log into the self-service portal if they like. This also means that existing ride offers won't be canceled (these should be canceled individually).

In the self-service portal, please also remove "Cancel drive offer" link.

In the self-service portal, add a link that allows drivers to reactivate notifications.

Limit out of radius proposed matches

Current algorithm proposed matches up to 100 miles away from the driver zip code, even outside of radius (but with a reduced score).
Based on user feedback, 100 miles seems to far away (indeed....)

The 100 miles tolerance is changes to 20 miles, based on the fact that some drivers have indicated that they are willing to drive a little bit out of their way, and the fact that our distance calculation is based on the geo coordinates of the zip and not the actual address of the driver.

In test environment, it is not possible to log into the self-service portal

Entering the phone number and clicking the login button doesn't result in any change on the page

Specify rider preferred contact method in driver notification SMS

Current SMS contains contact details but doesn't make it clear to driver which one is preferred.

Simply add (preferred) after the preferred contact method.

node index.js should generate UUID outside of INSERT

Need to generate UUID (v4) outside of INSERT, so we have it available to send notification back to submitter.
https://blog.tompawlak.org/generate-unique-identifier-nodejs-javascript

I added UUID columns as
UUID | character varying(50) | not null default gen_random_uuid()

However, the default value should not be used, unless we do bulk load of data

Rider does not currently receive a notification if a driver cancels a match

The driver receives a notification when the rider cancels but the rider doesn't receive one when the driver cancels.

They may end up waiting and not take action to find alternative transport. Let me know if you need copy for this!

Fix formatting of e-mail bodies

use some html

Dns setup for mailgun

Need DNS setup for mailgun to register carpoolvote.com domain

Remove driver zip and radius from rider match confirmation SMS

The available times are useful to the rider but the assumption will be that they are within the radius (and they may find it confusing if they are a little out).

invalid outgoing_sms table entry for proposed match

outgoing_sms table does not contain any text in the body field for a proposed match

Add license driver license plate number to rider match confirmations

In the SMS and email notifications that the rider receives after a driver has confirmed a match, please add: "Please check the license plate number before getting in: xxxxxxxxx"

This is a safety feature, so the rider know they're getting in the right vehicle.

Add Carpool Vote phone number to all rider SMS notifications

We'd like riders to be able to access the self-service portal even if they are not online. This would have to be done via an operator on the phone line.

Please add:
User support: 804-239-3389

Driver self-service portal perfect match says "Score: 0"

Unclear what this means, so probably also confusing for the driver

Add a user-friendly message to the cancellation page

I clicked the cancellation button in the email, and was directed to this page: https://api.carpoolvote.com/test/cancel-ride-request?UUID=b409c43a-b581-4a5c-831d-339c1783c8a9&RiderPhone=Westenra

Which just displayed the following text, completely unformatted: {"rider_cancel_ride_request":""}

Can we display something a little more user-friendly? At minimum, an <h1> saying something like "Your cancellation request has been received, thanks! You should receive an email shortly to confirm the cancellation." However ideally if we could display a proper HTML page, that'd go a long way. I can help with the design.

Service API URLs don't work when e-mail address is used

https://api.carpoolvote.com/test/accept-driver-match?UUID_driver=789132be-8c45-4173-a547-69d2417f0f97&UUID_rider=ef7bb862-c2f4-4c7b-9797-1fd91539c088&Score=600&[email protected]

It seem unable to match if e-mail address is used, no problem is phone number is used.

Is it a problem in node app, or URL encoding ?

How should I write links that I include in notification e-mails.

index.js - store driver license number

I see that the driver form now has field for Driver License Number

index.js should now be able to insert it too

Here is the corresponding field in the DB
DriverLicenseNumber | character varying(50) |

And VehicleRegistrationNumber is gone now I think, can be removed from index.js

Simplify drivers and rider UUIDs

These can be difficult to manage for people with cognitive difficulties

Is there something shorter/easier that can be assigned? Perhaps something to do with last name, initials, zip code etc?

Send rider contact details to driver only AFTER a match has been confirmed

Driver currently receives contact details for all proposed riders. Instead, they should only receive these details once they have confirmed the match. The street/apartment number should also be separated from the street name (issue #254 on the front end), so it can be sent along with the rest of the contact details.

This is for data protection and safety reasons. The driver can always cancel a match if it doesn't work for some reason.

In the notification above "If you do not wish to..." add "We will send you the rider's full address and contact details if you accept the match"

In self-service portal, allow drivers and to add notes next to add notes next to confirmed matches

Next to each confirmed match in the self-service portal (for drivers and riders), add a box that lets drivers/riders record notes for themselves.

This is especially useful for drivers, to keep track if they're arranging multiple rides.

Forms not redirecting to confirmation page after signup

Rider and driver signups no longer redirects to confirmation page after submission. Shows blank page with UUID instead.
Ditto for confirmation page when driver has confirmed a match, rider has cancelled a match, etc

Can we version the API (such that we could have two versions potentially in use at the same time?)

Something like:

https://api.carpoolvote.com/v1.0/drivers/
https://api.carpoolvote.com/v1.1/drivers/

https://api.carpoolvote.com/v1.0/riders/
https://api.carpoolvote.com/v1.1/riders/

https://api.carpoolvote.com/v1.0/helpers/
https://api.carpoolvote.com/v1.1/helpers/

https://api.carpoolvote.com/v2.0/zipcodelookup/

I suspect this would be multiple versions of the node app, running concurrently, in different directories, on different ports, and then nginx handling the routing from /v1.0/* to one port, and /v2.0/* to another port?

What do we do against SQL injection?

We have a few text fields, which will be displayed in the self-service page, and email.
Also the same text fields are used in APIs to manage the ride requests/driver offers.

What should we do against SQL injection ?

index.js - Store RiderAccommodationNotes from form into DB

Form now seems to send RiderAccommodationNotes (or at least it is there on the rider form)

We can now add code to index.js to store its value in DB

ip address logged in stage tables is always 127.0.0.1

Is this because it's all proxied by nginx ?

Add a route for Helpers

Allow the submission of Helper data.

Index.js to implement GET API for geo map data

Goal is to map unmatched riders

The first phase would be a simple descriptive map of current unmatched driver / rider locations so a simple table would be fine of lat, long, zip, and count, example here: https://github.com/voteamerica/voteamerica.github.io/tree/master/carpool-map/data

I'll provide a view stage.vw_unmatched_riders with the information collected from websumbission_rider and zip_codes tables

To Investigate why the counts don't add up

I can't explain why we have 207 matches in state MatchConfirmed, but only 57 riders in that state.
Normally, there is one match per rider at most

MATCHES
count | state
-------+----------------
800 | Canceled
946 | MatchProposed
207 | MatchConfirmed
(3 rows)

EMAILS
count | state
-------+--------
4940 | Sent
703 | Failed
(2 rows)

SMS
count | state
-------+--------
3040 | Sent
52 | Failed
(2 rows)

user action link return json object when clicked from an e-mail

For example, for accepting a match,
@jkbits1 Is there a way to return a plain string maybe to confirm success. Right now, it only returns the name of the action and an empty string.
It works, but it does not look nice.

unmatched drivers json has duplicate lat/lon information

[{"count":"1","zip":"20111","state":"VA","latitude":" 38.769697","longitude":" -77.44915","city":"Manassas","full_state":"Virginia","latitude_numeric":38.7697,"longitude_numeric":-77.4492,"latlong":{"x":38.7696952819824,"y":-77.4491500854492}}]

Rider and Driver self-service won't allow login

Error message:

"No Ride Request found for those parameters"
"No Drive Offer found for those parameters"

stage rider table should store complete destination address

On the rider form, there would be a polling station address finder.
The complete destination address should be stored in the database

impacts node.js app and possibly sweeper app.

Add driver's available drive times to rider confirmed match information in email and SMS notifications

This is useful information for the rider as a starting point for a conversation with the driver.

Incomplete nov2016.zip_codes table

There are only 33k zip codes out of approx 43k.
Need to find more comprehensive source

rider request not properly canceled

Rider sms
status | created_ts | last_updated_ts | recipient | emission_info
--------+----------------------------+----------------------------+------------+---------------
Sent | 2017-05-07 14:22:24.004371 | 2017-05-07 14:26:44.25842 | 5719691499 |
Sent | 2017-05-07 14:24:01.09684 | 2017-05-07 14:26:44.361226 | 5719691499 |
Sent | 2017-05-07 14:27:53.310019 | 2017-05-07 14:28:14.061146 | 5719691499 |
(3 rows)

Rider sms
status | created_ts | last_updated_ts | recipient | emission_info
---------+----------------------------+----------------------------+------------+---------------
Sent | 2017-05-07 14:22:24.004371 | 2017-05-07 14:26:44.25842 | 5719691499 |
Sent | 2017-05-07 14:24:01.09684 | 2017-05-07 14:26:44.361226 | 5719691499 |
Sent | 2017-05-07 14:27:53.310019 | 2017-05-07 14:28:14.061146 | 5719691499 |
Pending | 2017-05-07 14:29:47.914392 | 2017-05-07 14:29:47.914392 | 5719691499 |
(4 rows)

email sender incorrectly handles failures from mailgun api

recipient address was invalid, record in outgoing_email should have been marked as failed. did not happen

Add ride details to proposed match SMS

Proposed match SMS notifications going to the driver does not currently contain the details of the ride. We'd like to driver to have an idea of whether the ride could work, before they log in (especially if they've already set up a few rides), so that unnecessary logins don't become a burden.

Please include in the proposed match notifications:

Dates and am/pm
Start and end zip
Power chair needed (only if yes)
Special accommodation notes (only if any)

Have node app handle the _redirect if provided by redirecting the browser to the destination page.

    var redirTo = payload._redirect;

      [ insert the data]

   // redirect the browser to the URL specified in the "Redirect" form variable.
    reply.redirect(redirTo);

zip code 20021 is no in zip_codes table

to be investigated.
A rider record on live environment failed because of this

Allow drivers and riders to amend any of the ride or personal details in the self-service portal

On top-right of the main landing page in the self-service portal, include a button linking to “Modify details” page. On this page, include all of the information as recorded on the signup form. Allow modification of any of these details (except T&Cs).

Require user to click “Submit” button to save changes.
Prompt user to “Submit” or “Cancel” details if they try to leave after making changes without submitting.

This feature should relieve considerable pressure on the customer service team during election time.

After POST , redirect URL to use uuid_driver and uuid_rider as needed

I think it needs a change in the node app

voteamerica / backend Goto Github PK

backend's People

Contributors

Stargazers

Watchers

Forkers

backend's Issues

Driver accepts match

Rider cancels specific ride match (NOT entire ride request)

Rider cancels entire ride request

Driver confirms match but it's no longer available

Driver cancels specific ride match (NOT entire ride offer)

Recommend Projects

Recommend Topics

Recommend Org